Reland r114898: Add TabModalConfirmDialogDelegate.

Reland r114898: Add TabModalConfirmDialogDelegate to show simple tab-modal confirmation dialogs.

This CL carves a TabModalConfirmDialogDelegate class (modeled after ConfirmInfobarDelegate) out of RepostFormWarningController and makes it a subclass thereof.

It also removes the ShowRepostFormWarning method from BrowserWindow and its subclasses, in favor of a method in browser_dialogs.h.

[email protected],[email protected],[email protected],[email protected]
BUG=92795
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115000

[Bernhard Bauer, 2011-12-19 15:32:13]

Please review.

The old version of this CL is in patch set 2, for comparison (broke on
linux_aura).
Try job results are in patch set 1.

[battre, 2011-12-19 15:45:00]

On 2011/12/19 15:32:13, Bernhard Bauer wrote:
> Please review.
> 
> The old version of this CL is in patch set 2, for comparison (broke on
> linux_aura).
> Try job results are in patch set 1.

LGTM on changes from patch set 2 to patch set 3.

[commit-bot: I haz the power, 2011-12-19 16:07:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/8986005/13094

[commit-bot: I haz the power, 2011-12-19 18:03:10]

Change committed as 115000

[pfeldman, 2011-12-20 18:47:25]

http://codereview.chromium.org/8986005/diff/13094/chrome/browser/ui/gtk/tab_m...
File chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.cc (right):

http://codereview.chromium.org/8986005/diff/13094/chrome/browser/ui/gtk/tab_m...
chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.cc:35: dialog_ =
gtk_vbox_new(FALSE, ui::kContentAreaBorder);
This dialog is missing GetTitle call. Is this intentional?

[Bernhard Bauer, 2011-12-21 00:58:26]

http://codereview.chromium.org/8986005/diff/13094/chrome/browser/ui/gtk/tab_m...
File chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.cc (right):

http://codereview.chromium.org/8986005/diff/13094/chrome/browser/ui/gtk/tab_m...
chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.cc:35: dialog_ =
gtk_vbox_new(FALSE, ui::kContentAreaBorder);
On 2011/12/20 18:47:26, pfeldman wrote:
> This dialog is missing GetTitle call. Is this intentional?

It wasn't in the old version (repost_form_warning_gtk.cc), so I left it out here
as well.