Issue 9151022: Fix single release generation

Issue 9151022: Fix single release generation (Closed)

Created:
8 years, 11 months ago by noelallen1

Modified:
8 years, 11 months ago

Reviewers:
sehr (please use chromium)

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix single release generation Fix several cases where generating a single release will fail because the object was defined at a previous release, and the UniqueRelease check was returning an empty set. BUG=109679 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117048

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -11 lines)			Patch
M	ppapi/generators/idl_c_header.py	View	1	4 chunks	+14 lines, -2 lines	0 comments	Download
M	ppapi/generators/idl_c_proto.py	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	ppapi/generators/idl_generator.py	View	1	3 chunks	+6 lines, -1 line	0 comments	Download
M	ppapi/generators/idl_node.py	View		1 chunk	+37 lines, -7 lines	4 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sehr (please use chromium)

Couple of nits. Fix and LGTM. http://codereview.chromium.org/9151022/diff/2001/ppapi/generators/idl_node.py File ppapi/generators/idl_node.py (right): http://codereview.chromium.org/9151022/diff/2001/ppapi/generators/idl_node.py#newcode266 ppapi/generators/idl_node.py:266: # Only add ...

8 years, 11 months ago (2012-01-10 14:40:23 UTC) #2

noelallen1

8 years, 11 months ago (2012-01-10 18:06:55 UTC) #3

http://codereview.chromium.org/9151022/diff/2001/ppapi/generators/idl_node.py
File ppapi/generators/idl_node.py (right):

http://codereview.chromium.org/9151022/diff/2001/ppapi/generators/idl_node.py...
ppapi/generators/idl_node.py:266: # Only add it, if the hash is different
On 2012/01/10 14:40:24, sehr wrote:
> nit: drop the comma.

Done.

http://codereview.chromium.org/9151022/diff/2001/ppapi/generators/idl_node.py...
ppapi/generators/idl_node.py:273: # use first availible release names and remove
duplicates.
On 2012/01/10 14:40:24, sehr wrote:
> available

Done.

Expand Messages | Collapse Messages