cc: Misc animation refactoring

cc: Misc animation refactoring

Make animation code conform to the style guide by using auto where
appropriate, renaming functions named incorrectly, etc. Avoid
accessing layer_animation_controller directly where possible.

Committed: https://crrev.com/ea328be16b456a4bd79a16579a3105858b8421d5
Cr-Commit-Position: refs/heads/master@{#318195}

[sunnyps, 2015-02-24 05:37:50]

[email protected] changed reviewers:
+ [email protected], [email protected]

[sunnyps, 2015-02-24 05:38:08]

No change in functionality here. PTAL.

[sunnyps, 2015-02-24 06:22:25]

https://codereview.chromium.org/948243003/diff/20001/cc/trees/layer_tree_impl.h
File cc/trees/layer_tree_impl.h (right):

https://codereview.chromium.org/948243003/diff/20001/cc/trees/layer_tree_impl...
cc/trees/layer_tree_impl.h:242: AnimationRegistrar* animation_registrar() const;
I know this method is not inlined and is yet using snake_case. The google style
guide is vague about this, it says "simple" method can be named in snake_case.
However the main reason for doing this is that C++ hates using the same function
name as the class (it fails to compile on certain bots). Between this and the
other option (animationRegistrar), I chose this because other methods in the
class are named in a similar way.

[danakj, 2015-02-24 07:21:17]

https://codereview.chromium.org/948243003/diff/20001/cc/trees/layer_tree_impl.h
File cc/trees/layer_tree_impl.h (right):

https://codereview.chromium.org/948243003/diff/20001/cc/trees/layer_tree_impl...
cc/trees/layer_tree_impl.h:242: AnimationRegistrar* animation_registrar() const;
On 2015/02/24 06:22:25, sunnyps wrote:
> I know this method is not inlined and is yet using snake_case. The google
style
> guide is vague about this, it says "simple" method can be named in snake_case.
> However the main reason for doing this is that C++ hates using the same
function
> name as the class (it fails to compile on certain bots). Between this and the
> other option (animationRegistrar), I chose this because other methods in the
> class are named in a similar way.

I think what you want is GetAnimationRegistrar(). We dont use Get enough in cc
(due to WebKit history I think).  Verbs are good.

[ajuma, 2015-02-24 16:21:42]

lgtm modulo danakj's comment.

[sunnyps, 2015-02-24 20:13:37]

PTAL

https://codereview.chromium.org/948243003/diff/20001/cc/trees/layer_tree_impl.h
File cc/trees/layer_tree_impl.h (right):

https://codereview.chromium.org/948243003/diff/20001/cc/trees/layer_tree_impl...
cc/trees/layer_tree_impl.h:242: AnimationRegistrar* animation_registrar() const;
On 2015/02/24 07:21:17, danakj wrote:
> On 2015/02/24 06:22:25, sunnyps wrote:
> > I know this method is not inlined and is yet using snake_case. The google
> style
> > guide is vague about this, it says "simple" method can be named in
snake_case.
> > However the main reason for doing this is that C++ hates using the same
> function
> > name as the class (it fails to compile on certain bots). Between this and
the
> > other option (animationRegistrar), I chose this because other methods in the
> > class are named in a similar way.
> 
> I think what you want is GetAnimationRegistrar(). We dont use Get enough in cc
> (due to WebKit history I think).  Verbs are good. 

Done.

[danakj, 2015-02-26 02:06:20]

LGTM sorry for the slow review. Can u say something a bit more in your patch
desc so someone reading git log can have an idea what u did here?

[sunnyps, 2015-02-26 02:14:47]

The CQ bit was checked by [email protected]

[sunnyps, 2015-02-26 02:14:47]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected]
Link to the patchset: https://codereview.chromium.org/948243003/#ps40001 (title:
"Address danakj's comment.")

[sunnyps, 2015-02-26 02:15:23]

On 2015/02/26 02:06:20, danakj wrote:
> LGTM sorry for the slow review. Can u say something a bit more in your patch
> desc so someone reading git log can have an idea what u did here?

Done.

[commit-bot: I haz the power, 2015-02-26 02:15:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/948243003/40001

[commit-bot: I haz the power, 2015-02-26 06:03:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-26 06:04:39]

Patchset 3 (id:??) landed as
https://crrev.com/ea328be16b456a4bd79a16579a3105858b8421d5
Cr-Commit-Position: refs/heads/master@{#318195}