[iOS] Upstream ios/chrome/browser code

[iOS] Upstream ios/chrome/browser code

This CL upstreams several iOS source files.
It also fixes net.gyp so that url_conversions are compiled and
tested on iOS.

Committed: https://crrev.com/f83b9126a7b0cc8955a5964e7ef27a5b7ebf8e10
Cr-Commit-Position: refs/heads/master@{#319305}

[droger, 2015-03-05 10:20:50]

Patchset #1 (id:1) has been deleted

[droger, 2015-03-05 10:24:00]

Patchset #1 (id:20001) has been deleted

[droger, 2015-03-05 10:25:57]

[email protected] changed reviewers:
+ [email protected]

[sdefresne, 2015-03-05 15:36:44]

https://codereview.chromium.org/979073002/diff/40001/ios/chrome/browser/chrom...
File ios/chrome/browser/chrome_switches.h (right):

https://codereview.chromium.org/979073002/diff/40001/ios/chrome/browser/chrom...
ios/chrome/browser/chrome_switches.h:5: // Defines all the command-line switches
used by Chrome.
nit: can you move this below #include guard? And change Chrome to Chrome on iOS.

https://codereview.chromium.org/979073002/diff/40001/ios/chrome/browser/pref_...
File ios/chrome/browser/pref_names.cc (right):

https://codereview.chromium.org/979073002/diff/40001/ios/chrome/browser/pref_...
ios/chrome/browser/pref_names.cc:23: // *************** PROFILE PREFS
***************
I think this should use Chrome Browser State instead of profile everywhere.

https://codereview.chromium.org/979073002/diff/40001/ios/chrome/browser/ui/co...
File ios/chrome/browser/ui/commands/set_up_for_testing_command.mm (right):

https://codereview.chromium.org/979073002/diff/40001/ios/chrome/browser/ui/co...
ios/chrome/browser/ui/commands/set_up_for_testing_command.mm:36: // Note:
Ideally this would be rewritten to use GetValueForKeyInQuery.
I'd say we either want to remove this comment or change it to a // TODO(ios):
rewrite this to use GetValueForKeyInQuery.

https://codereview.chromium.org/979073002/diff/40001/ios/chrome/browser/ui/co...
File ios/chrome/browser/ui/commands/show_accounts_settings_command.mm (right):

https://codereview.chromium.org/979073002/diff/40001/ios/chrome/browser/ui/co...
ios/chrome/browser/ui/commands/show_accounts_settings_command.mm:12: self =
[super initWithTag:IDC_SHOW_ACCOUNTS_SETTINGS];
nit: return [super initWithTag:...];

[droger, 2015-03-05 15:51:51]

Thanks, all done.

[sdefresne, 2015-03-05 15:54:14]

The CQ bit was checked by [email protected]

[sdefresne, 2015-03-05 15:54:15]

lgtm

[commit-bot: I haz the power, 2015-03-05 15:55:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/979073002/60001

[droger, 2015-03-05 15:55:20]

[email protected] changed reviewers:
+ [email protected], [email protected]

[droger, 2015-03-05 15:55:21]

+mef OWNER for net.gyp
+rsesek OWNER for the google_toolbox_for_mac addition in ios/chrome/DEPS

[droger, 2015-03-05 15:55:56]

The CQ bit was unchecked by [email protected]

[Robert Sesek, 2015-03-05 18:31:11]

DEPS LGTM

[droger, 2015-03-05 18:41:55]

[email protected] changed reviewers:
+ [email protected]
- [email protected]

[droger, 2015-03-05 18:41:55]

-mef (OOO)
+ rdsmith as OWNER of net.gyp

[Randy Smith (Not in Mondays), 2015-03-05 19:04:37]

net.gyp LGTM.

[droger, 2015-03-05 19:06:28]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2015-03-05 19:07:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/979073002/60001

[commit-bot: I haz the power, 2015-03-05 19:45:37]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2015-03-05 19:46:18]

Patchset 2 (id:??) landed as
https://crrev.com/f83b9126a7b0cc8955a5964e7ef27a5b7ebf8e10
Cr-Commit-Position: refs/heads/master@{#319305}