Move DumpProcessWithoutCrash to base, so we can use it from net and content

Move DumpProcessWithoutCrash to base, so we can use it from net and content

BUG=none
[email protected]
[email protected]

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241589

[jochen (gone - plz use gerrit), 2013-12-17 19:01:04]

plz review

[Mark Mentovai, 2013-12-17 20:12:08]

https://codereview.chromium.org/99523009/diff/20001/base/debug/dump_without_c...
File base/debug/dump_without_crashing.cc (right):

https://codereview.chromium.org/99523009/diff/20001/base/debug/dump_without_c...
base/debug/dump_without_crashing.cc:16: void (__cdecl
*dump_without_crashing_function_)() = NULL;
All of these #ifdefs just for __cdecl. It’d read much more cleanly if you had
some MACRO you could use to specify the calling convention attribute. Even
better, maybe all you really need is a typedef inside an #ifdef, and you can
eschew the macro grossness altogether.

https://codereview.chromium.org/99523009/diff/20001/base/debug/dump_without_c...
File base/debug/dump_without_crashing.h (right):

https://codereview.chromium.org/99523009/diff/20001/base/debug/dump_without_c...
base/debug/dump_without_crashing.h:1: // Copyright 2013 The Chromium Authors.
All rights reserved.
It would be awesome if this showed up as a copy from svn’s perspective. Check
--similarity?

[jochen (gone - plz use gerrit), 2013-12-18 08:41:46]

PTAL

[Mark Mentovai, 2013-12-18 13:47:49]

LGTM

https://codereview.chromium.org/99523009/diff/50001/base/compiler_specific.h
File base/compiler_specific.h (right):

https://codereview.chromium.org/99523009/diff/50001/base/compiler_specific.h#...
base/compiler_specific.h:215: #if defined(OS_WIN) && !defined(CDECL)
When would CDECL be already defined? Because if it might be defined by something
like this snippet…

https://codereview.chromium.org/99523009/diff/50001/base/compiler_specific.h#...
base/compiler_specific.h:218: #define CDECL
…it might also be defined for non-Windows, and this could be a problem because
you only checked !defined for OS_WIN.

[jochen (gone - plz use gerrit), 2013-12-18 14:49:40]

TBR'ing wez for remoting/

https://codereview.chromium.org/99523009/diff/50001/base/compiler_specific.h
File base/compiler_specific.h (right):

https://codereview.chromium.org/99523009/diff/50001/base/compiler_specific.h#...
base/compiler_specific.h:215: #if defined(OS_WIN) && !defined(CDECL)
On 2013/12/18 13:47:49, Mark Mentovai wrote:
> When would CDECL be already defined? Because if it might be defined by
something
> like this snippet…

no idea, I just copied this verbatim from native_library.h

https://codereview.chromium.org/99523009/diff/50001/base/compiler_specific.h#...
base/compiler_specific.h:218: #define CDECL
On 2013/12/18 13:47:49, Mark Mentovai wrote:
> …it might also be defined for non-Windows, and this could be a problem because
> you only checked !defined for OS_WIN.

I wrapped the entire block in #if !defined(CDECL)

[commit-bot: I haz the power, 2013-12-18 14:51:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/99523009/70001

[commit-bot: I haz the power, 2013-12-18 17:42:33]

Change committed as 241589

[Wez, 2013-12-30 15:24:23]

LGTM, FWIW