| commit | 3c5235a67acbaf8f7a86e2d0780d34cfaea696e3 | [log] [tgz] |
|---|---|---|
| author | Vaibhav Rustagi <[email protected]> | Mon Mar 21 17:03:11 2022 -0700 |
| committer | COS Cherry Picker <[email protected]> | Tue Mar 22 19:03:39 2022 -0700 |
| tree | 637033999243eb5c6216f12cf9391dffc4d34e63 | |
| parent | 438073c9f4709183255dbb94f624942ae730ae59 [diff] |
esp: Fix possible buffer overflow in ESP transformation
[ Upstream commit ebe48d368e97d007bfeb76fcb065d6cfc4c96645 ]
The maximum message size that can be send is bigger than
the maximum site that skb_page_frag_refill can allocate.
So it is possible to write beyond the allocated buffer.
Fix this by doing a fallback to COW in that case.
v2:
Avoid get get_order() costs as suggested by Linus Torvalds.
For having the patch build on v5.10, `SKB_FRAG_PAGE_ORDER` declaration
is moved from net/core/sock.c to include/net/sock.c.
BUG=b/225430954
TEST=presubmit
RELEASE_NOTE=Fixed possible buffer overflow in ESP transformation.
cos-patch: bug
Fixes: cac2661c53f3 ("esp4: Avoid skb_cow_data whenever possible")
Fixes: 03e2a30f6a27 ("esp6: Avoid skb_cow_data whenever possible")
Reported-by: valis <[email protected]>
Signed-off-by: Steffen Klassert <[email protected]>
Signed-off-by: Vaibhav Rustagi <[email protected]>
Change-Id: Ibba7d1063e1e78fe8cecb2d0ae1e94a586101a93
Reviewed-on: https://cos-review.googlesource.com/c/third_party/kernel/+/31062
Reviewed-by: Oleksandr Tymoshenko <[email protected]>
Main-Branch-Verified: Cusky Presubmit Bot <[email protected]>
Tested-by: Cusky Presubmit Bot <[email protected]>