setopt: provide info for CURLE_BAD_FUNCTION_ARGUMENT #17337
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If CURLE_BAD_FUNCTION_ARGUMENT is returned and failf() has not provided any details, this adds a generic error string that includes the option number. This helps debugging for example the curl tool which does a lot of setopt calls and in reading post fact logs it is not always easy to tell exactly which call that failed.
|
Turns out 17330 is unaffected by this. Could still be useful for other cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If CURLE_BAD_FUNCTION_ARGUMENT is returned and failf() has not provided any details, this adds a generic error string that includes the option number.
This helps debugging for example the curl tool which does a lot of setopt calls and in reading post fact logs it is not always easy to tell exactly which call that failed.
Ref: #17330