libssh: split up the state machine function #17346
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the "complexity score" for myssh_statemach_act from 160 to 100, taking it down from the most complex function in libcurl to the 5th. Also fixes a memory leak of the sftp session.
|
Analysis of PR #17346 at 1cc408ae: Test 622 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
To make sure we run libssh tests with valgrind enabled
|
🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the "complexity score" for myssh_statemach_act from 160 to 100, taking it down from the most complex function in libcurl to the 5th.
Also fixes a memory leak of the sftp session.