Skip to content

[dotnet] disable some features by default #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2025
Merged

[dotnet] disable some features by default #553

merged 1 commit into from
Mar 27, 2025

Conversation

lucaspimentel
Copy link
Member

@lucaspimentel lucaspimentel commented Feb 14, 2025 •
edited
Loading

Stacked on #623. Merged that PR first. ✅

By default, disable a few unused features in dd-trace-dotnet to improve startup times and total execution times:

env var name Description
DD_TRACE_STARTUP_LOGS=0 skip generating the startup log entry (which writes to the file system)
DD_CIVISIBILITY_ENABLED=0 explicitly disable CI Visibility to skip it's auto-detection logic

@lucaspimentel lucaspimentel changed the title Lpimentel/dotnet disable unused features [dotnet] disable unused features Feb 14, 2025
@lucaspimentel lucaspimentel force-pushed the lpimentel/dotnet-disable-unused-features branch from acca3c4 to 71938d4 Compare February 21, 2025 23:13
@lucaspimentel lucaspimentel force-pushed the lpimentel/dotnet-disable-unused-features branch from 71938d4 to 4fa833c Compare March 26, 2025 19:50
@lucaspimentel lucaspimentel changed the title [dotnet] disable unused features [dotnet] allow disabling tracer, disable unused features by default Mar 26, 2025
@lucaspimentel lucaspimentel changed the title [dotnet] allow disabling tracer, disable unused features by default [dotnet] don't override env vars, disable unused features by default Mar 26, 2025
@lucaspimentel lucaspimentel requested review from a team March 26, 2025 20:13
@lucaspimentel lucaspimentel force-pushed the lpimentel/dotnet-disable-unused-features branch 3 times, most recently from a0461fc to b0f133f Compare March 26, 2025 20:41
@lucaspimentel lucaspimentel changed the base branch from main to lpimentel/dont-override-user-env-vars March 26, 2025 20:41
@lucaspimentel lucaspimentel changed the title [dotnet] don't override env vars, disable unused features by default [dotnet] disable some features by default Mar 26, 2025
@lucaspimentel lucaspimentel marked this pull request as ready for review March 26, 2025 21:25
@lucaspimentel lucaspimentel requested a review from a team as a code owner March 26, 2025 21:25
Base automatically changed from lpimentel/dont-override-user-env-vars to main March 26, 2025 23:10
@lucaspimentel lucaspimentel force-pushed the lpimentel/dotnet-disable-unused-features branch from b0f133f to 01091ea Compare March 26, 2025 23:17
@lucaspimentel lucaspimentel force-pushed the lpimentel/dotnet-disable-unused-features branch from 01091ea to a09c289 Compare March 26, 2025 23:20
hghotra
hghotra approved these changes Mar 27, 2025
View reviewed changes
Copy link

@hghotra hghotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@lucaspimentel lucaspimentel merged commit 5aa3a01 into main Mar 27, 2025
45 checks passed
@lucaspimentel lucaspimentel deleted the lpimentel/dotnet-disable-unused-features branch March 27, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hghotra hghotra hghotra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucaspimentel @hghotra