Skip to content

feat: Add readiness debug log #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2025
Merged

feat: Add readiness debug log #607

merged 3 commits into from
Mar 13, 2025

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Mar 13, 2025

Adds a debug message with our init duration for the extension specifically, measured by the time main begins to the time we call /next
aids in debugging/disambiguation cases
image

@astuyve astuyve requested a review from a team as a code owner March 13, 2025 17:32
Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – wondering if we should merge the log that says "vXX version of the Datadog Extension", we can just add version and time it started in the same one, me thinks

@astuyve
Copy link
Contributor Author

astuyve commented Mar 13, 2025

I don't think so, because a lot can go wrong between when that log is emitted and we're done booting – I want to make sure we get the version number even if we fail to start, or fail over, for some reason.

@astuyve astuyve merged commit 8aa7ac2 into main Mar 13, 2025
33 checks passed
@astuyve astuyve deleted the aj/readiness-debug-log branch March 13, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants