feat: Register first in main #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanista
reviewed
Apr 11, 2025
| let client = Client::builder().no_proxy().build().map_err(|e| { | ||
| Error::new( | ||
| std::io::ErrorKind::InvalidData, | ||
| format!("Failed to create client: {e:?}"), | ||
| ) | ||
| })?; | ||
|
|
||
| let r = register(&client) |
There was a problem hiding this comment.
Should we modify the logs in register to be println! in case they're from the tracing library which might not be enabled by now?
There was a problem hiding this comment.
I don't think we debug at all? We're only calling panic!() if we receive a non-200 status code from the register API call, which will crash the process and print to stdout
duncanista
approved these changes
Apr 11, 2025
astuyve
added a commit
that referenced
this pull request
Apr 11, 2025
Reverts #645 This breaks failover as we handle _that part_ in config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need any configuration options in order to register the extension, so make that request first.