feat: Optionally disable proc enhanced metrics #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanista
reviewed
Apr 24, 2025
bottlecap/src/config/env.rs
Outdated
| @@ -38,6 +38,7 @@ pub struct Config { | |||
| pub logs_config_logs_dd_url: String, | |||
| pub serverless_flush_strategy: FlushStrategy, | |||
| pub enhanced_metrics: bool, | |||
| pub proc_enhanced_metrics: bool, | |||
There was a problem hiding this comment.
should we include anything lambda|serverless related?
There was a problem hiding this comment.
Hmmm, why? Today enhanced metrics as a concept only apply to lambda/serverless
There was a problem hiding this comment.
idk, just trying to be cautious about adding new env vars
There was a problem hiding this comment.
okay I can add lambda
There was a problem hiding this comment.
just a nit, i trust your gut 🫡
duncanista
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #648
For customers using very very fast/small lambda functions (usually just rust), there can be a small 1-2ms increase in runtime duration when collecing metrics like open file descriptors or tmp file usage.
We still enable these by default, but customers can now optionally disable them