Skip to content

fix(injector: config): better error message when orchestrion.tool.go is missing #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

eliottness
Copy link
Contributor

Better error messages for cases like #535

@eliottness eliottness marked this pull request as ready for review February 7, 2025 14:06
@eliottness eliottness requested a review from a team as a code owner February 7, 2025 14:06
@eliottness eliottness enabled auto-merge February 7, 2025 14:12
@eliottness eliottness added this pull request to the merge queue Feb 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 7, 2025
@eliottness eliottness added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit 1ceb738 Feb 7, 2025
43 checks passed
@eliottness eliottness deleted the eliott.bouhana/better-error branch February 7, 2025 23:25
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.80%. Comparing base (0ef21f0) to head (55d3d31).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
internal/jobserver/buildid/version.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
- Coverage   67.87%   66.80%   -1.07%     
==========================================
  Files         104      104              
  Lines        6733     6736       +3     
==========================================
- Hits         4570     4500      -70     
- Misses       1697     1792      +95     
+ Partials      466      444      -22     
Components Coverage Δ
Generators 46.17% <ø> (ø)
Instruments ∅ <ø> (∅)
Go Driver 75.89% <ø> (ø)
Toolexec Driver 58.49% <ø> (ø)
Aspects 75.61% <ø> (ø)
Injector 75.09% <100.00%> (+0.35%) ⬆️
Job Server 67.39% <0.00%> (-3.71%) ⬇️
Other 66.80% <83.33%> (-1.07%) ⬇️
Files with missing lines Coverage Δ
internal/injector/config/config-go.go 75.49% <100.00%> (+10.84%) ⬆️
internal/jobserver/buildid/version.go 72.18% <0.00%> (ø)

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants