Skip to content

feat: gracefully upgrade from v1 to v2-based setup #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2025

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Jul 15, 2025

Have orchestrion pin transparently replace gopkg.in/DataDog/dd-trace-go.v1 imports with github.com/DataDog/dd-trace-go/orchestrion/all/v2 while also ensuring any outstanding gopkg.in/DataDog/dd-trace-go.v1 is at least at v1.74.0.

This makes it more straight forward to upgrade to "natively v2" configuration.

@RomainMuller RomainMuller requested a review from a team as a code owner July 15, 2025 09:46
@github-actions github-actions bot added the conventional-commit/feat Feature work label Jul 15, 2025
@RomainMuller RomainMuller requested a review from eliottness July 15, 2025 10:07
@eliottness eliottness enabled auto-merge July 15, 2025 10:21
@eliottness eliottness added this pull request to the merge queue Jul 15, 2025
Merged via the queue into main with commit 739f52a Jul 15, 2025
59 checks passed
@eliottness eliottness deleted the romain.marcadier/pin-upgrade-to-v2 branch July 15, 2025 11:04
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 53.05%. Comparing base (e01054e) to head (4a9d73a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/pin/pin.go 56.25% 5 Missing and 2 partials ⚠️

❗ There is a different number of reports uploaded between BASE (e01054e) and HEAD (4a9d73a). Click for more details.

HEAD has 13 uploads less than BASE
Flag BASE (e01054e) HEAD (4a9d73a)
Windows 1 0
ARM64 1 0
GOFLAGS 1 0
generators 1 0
X64 1 0
Linux 1 0
TOOLEXEC 1 0
macOS 1 0
integration 1 0
go1.24 1 0
go1.25rc2 1 0
DRIVER 1 0
go1.23 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #661       +/-   ##
===========================================
- Coverage   68.50%   53.05%   -15.46%     
===========================================
  Files         113      112        -1     
  Lines        7916     7717      -199     
===========================================
- Hits         5423     4094     -1329     
- Misses       1954     3221     +1267     
+ Partials      539      402      -137     
Components Coverage Δ
Generators 0.00% <ø> (-80.25%) ⬇️
Instruments ∅ <ø> (∅)
Go Driver 49.06% <ø> (-27.45%) ⬇️
Toolexec Driver 23.42% <ø> (-47.41%) ⬇️
Aspects 65.04% <ø> (-9.29%) ⬇️
Injector 67.56% <ø> (-7.31%) ⬇️
Job Server 54.79% <ø> (-14.44%) ⬇️
Other 53.05% <56.25%> (-15.46%) ⬇️
Files with missing lines Coverage Δ
internal/pin/pin.go 61.15% <56.25%> (+1.67%) ⬆️

... and 52 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants