Fix deep overrides #108
Merged
Fix deep overrides #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An override like inputs.foo.inputs.bar.inputs.nixpkgs.follows = "nixpkgs"; implicitly set `inputs.foo.inputs.bar` to `flake:bar`, which led to an unexpected error like error: cannot find flake 'flake:bar' in the flake registries We now no longer create a parent override (like for `foo.bar` in the example above) if it doesn't set an explicit ref or follows attribute. We only recursively apply its child overrides. Fixes NixOS#8325, #95, NixOS#12083, NixOS#5790.
Taken from NixOS#6621. Co-authored-by: Sebastian Ullrich <[email protected]>
Having both doesn't make sense so it's best to disallow it. If this causes issues we could turn into a warning.
cole-h
reviewed
Jun 19, 2025
| OverrideTarget { | ||
| .input = inputOverride, | ||
| .sourcePath = sourcePath, | ||
| .parentInputAttrPath = inputAttrPathPrefix |
There was a problem hiding this comment.
Should this also be changed to prefix like line 472 above was?
There was a problem hiding this comment.
I think this is correct because it's the input attr path used to resolve relative path inputs. In an override, these should refer to the attr path of the overriding flake, which is inputAttrPathPrefix.
cole-h
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
An override like
implicitly set
inputs.foo.inputs.bartoflake:bar, which led to an unexpected error likeWe now no longer create a parent override (like for
foo.barin the example above) if it doesn't set an explicit ref or follows attribute. We only recursively apply its child overrides.Fixes NixOS#8325, #95, NixOS#12083, NixOS#5790. Based in part on NixOS#6621 by @Kha.
Also, we now disallow having both a flakeref and a follows attribute on an input, since it doesn't make sense to have both.
Context