Skip to content

Fix fetchToStore() caching with --impure, improve testing #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2025
Merged

Fix fetchToStore() caching with --impure, improve testing #117

merged 3 commits into from
Jun 19, 2025

Conversation

edolstra
Copy link
Collaborator

@edolstra edolstra commented Jun 16, 2025 •
edited
Loading

Motivation

Context

@edolstra edolstra force-pushed the test-uncacheable branch 4 times, most recently from e3da946 to 3a4e6ca Compare June 17, 2025 08:31
@edolstra edolstra marked this pull request as ready for review June 17, 2025 08:31
cole-h
cole-h approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from my feelings about making it barf everywhere in the test suite by default

@edolstra edolstra added this pull request to the merge queue Jun 19, 2025
Merged via the queue into detsys-main with commit 692dfb4 Jun 19, 2025
65 checks passed
@edolstra edolstra deleted the test-uncacheable branch June 19, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edolstra @cole-h