tests(gather-runner): replace getMockedEmulationDriver w/ mock-commands #10136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Dec 21, 2019
exterkamp
reviewed
Jan 9, 2020
| }); | ||
|
|
||
| connectionStub.sendCommand.findInvocation('Emulation.setDeviceMetricsOverride'); |
There was a problem hiding this comment.
Put an expectation around this?
expect(connectionStub.sendCommand.findInvocation('Emulation.setDeviceMetricsOverride')).toBeDefined()There was a problem hiding this comment.
shouldn't be necessary FYI, findInvocation does the assertion already
There was a problem hiding this comment.
I don't love the API for it, findInvocation doesn't really imply that it is asserting behind the scenes. Seems like there should be two functions findInvocation and expectInvocationExists, or expect out here. But @connorjclark mentioned that this is used a lot, so might be a separate large scale change.
| driver, | ||
| settings: { | ||
| extraHeaders: headers, | ||
| extraHeaders, |
exterkamp
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About to make this file typecheck'd - this was a refactor that needed to be done.