Skip to content

cli: --chrome-ignore-default-flags #10184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2020
Merged

cli: --chrome-ignore-default-flags #10184

merged 2 commits into from
Jan 7, 2020

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Jan 7, 2020 •
edited
Loading

fixes #3946

no test b/c this is trivial and there didn't seem to be a good way to test run.js getDebuggableChrome

patrickhulce
patrickhulce approved these changes Jan 7, 2020
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@connorjclark connorjclark merged commit 96e1046 into master Jan 7, 2020
@connorjclark connorjclark deleted the chrome-ignore-default-flags branch January 7, 2020 18:10
This was referenced Jan 27, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish Awaiting requested review from paulirish

1 more reviewer

@patrickhulce patrickhulce patrickhulce approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support --ignore-default-chrome-flags in CLI
3 participants
@connorjclark @patrickhulce @googlebot