report: fix ghost menu in print #10216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** ***Problem*** Print displays the tools drop down menu, rendering behind the category headings. ***Root cause*** The drop down menu is made hidden by the CSS `visibility: hidden` and toggled to `visibility: visible` when displayed to users and the print media does not support this property (citation needed). ***Solution*** Use `display: none` for the `print` media query to hide it (print media does not support drop drop interactions).
|
FYI @connorjclark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Print displays the tools drop down menu, rendering behind the category
headings.
Screenshot of menu rendered in report print preview
Root cause
The drop down menu is made hidden by the CSS
visibility: hiddenandtoggled to
visibility: visiblewhen displayed to users and the printmedia does not support this property (citation needed).
Solution
Use
display: nonefor theprintmedia query to hide it (print mediadoes not support drop drop interactions).
Screenshot of menu hidden in report print preview
