misc(compare-runs): fix filter, allow for resume, reorganize output #10519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
requested changes
Mar 27, 2020
| @@ -117,25 +117,32 @@ function round(value) { | |||
| * @return {string} | |||
| */ | |||
| function getProgressBar(i, total = argv.n * argv.urls.length) { | |||
| return new Array(Math.round(i * 40 / total)).fill('▄').join('').padEnd(40); | |||
| const bars = new Array(Math.round(i * 40 / total)).fill('▄').join('').padEnd(40); | |||
| return `${i} / ${total} [${bars}]`; | |||
There was a problem hiding this comment.
the math here is off. i is unique per URL and you want i+1
here's a good repro:
node lighthouse-core/scripts/compare-runs.js --name my-collectiondeleteme --gather -n 2 --urls https://www.example.com http://example.comThere was a problem hiding this comment.
I forgot to push this exact fix :(
| } | ||
|
|
||
| if (includeFilter && !includeFilter.test(result.key)) { | ||
| if (includeFilter && !includeFilter.test(result.name)) { |
There was a problem hiding this comment.
keeping it on key meant you can do --filter=metric (which is documented and i really like)
we could use something else for metric/timing filtering vs this regex on name tho.
There was a problem hiding this comment.
ah, just had to move this filter check before the property delete :)
paulirish
approved these changes
Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--filterwas broken from the last change