misc: close variability issues to master issue #10658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
approved these changes
Apr 29, 2020
| body: 'Thanks! Appreciate you filing this bug. :clap: | ||
|
|
||
|
|
||
| This is a known issue, most well described in #10657. So, **we''ll automatically |
There was a problem hiding this comment.
weird way to escape ' but ok yaml :P
| labels: | ||
| $and: | ||
| - $includes: pending-close | ||
| - $includes: variability |
There was a problem hiding this comment.
I feel like this is going to auto-trigger at some point for an issue that's about variability but shouldn't be deduped and then someone's going to add pending-close when the issue is wrapping up and it's going to be all confusing, but I guess that's unlikely to happen often :)
There was a problem hiding this comment.
heh, maybe we'll see :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
All ya gotta do to have the bot close these issues in the future is add "pending-close" and "variability"
Current set of issues: https://github.com/GoogleChrome/lighthouse/issues?q=is%3Aopen+is%3Aissue+label%3Avariability+label%3Apending-close
Related Issues/PRs
#10657