core: remove length check from csv report test #10675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Apr 30, 2020
| @@ -101,7 +101,6 @@ describe('ReportGenerator', () => { | |||
| fs.writeFileSync(path, csvOutput); | |||
|
|
|||
| const lines = csvOutput.split('\n'); | |||
| expect(lines).toHaveLength(145); | |||
There was a problem hiding this comment.
can I sell you on expect(lines.length).toBeGreaterThan(100) or some such thing that ensures a bunch of audits made it through? :)
There was a problem hiding this comment.
I'm sold. As long as we don't have to update it all the time :)
|
fyi @patrickhulce @Beytoven the title here should have been |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check would we need to be updated every time an audit is added or removed. Could become a nuisance in time.