misc(build): fix npm link issue #10682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
reviewed
Apr 30, 2020
| @@ -12,7 +12,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "build-all": "npm-run-posix-or-windows build-all:task", | |||
| "build-all:task": "(yarn build-cdt-lib & yarn build-extension & yarn build-devtools & yarn build-lr & yarn build-viewer & yarn build-smokehouse-bundle & wait) && yarn build-pack", | |||
| "build-all:task": "yarn build-cdt-lib && yarn build-devtools && (yarn build-extension & yarn build-lr & yarn build-viewer & yarn build-smokehouse-bundle & wait) && yarn build-pack", | |||
There was a problem hiding this comment.
build-cdt-lib could be in the parallel group though, right?
There was a problem hiding this comment.
so the results of cdt-lib are actually checked into git. if the output varies at all from what is in source control then CI will fail.
I made it happen before just because if you were to run this script locally, you'd want the CDT lib changes to be picked up by the build-devtools step.
|
is there a discussion or a CI failure to link to? Not sure what this is fixing :) |
|
oh jk paul added it :) |
|
This is blocking PRs, reviews plz. @brendankenny @paulirish |
paulirish
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should do the linking stuff first, and not in parallel with other commands
let's see if it works
fixes #10680