Skip to content

Conversation

Malvoz
Copy link
Contributor

@Malvoz Malvoz commented Nov 19, 2019

Adding the English keywords:

  • information
  • more info
  • more information
  • read more
  • see more

And common Swedish terms used as link text (Google Translate links provided if you wish to confirm the meaning of the words):

@Malvoz Malvoz changed the title link-text.js: Add more keywords to blocklist Add more keywords to blocklist (link-text.js) Nov 19, 2019
@connorjclark
Copy link
Collaborator

@team if we are going to add more english phrases, we should consider moving this to our i18n pipeline. Otherwise, all the other languages will be missing these new phrases.

@Malvoz Malvoz changed the title Add more keywords to blocklist (link-text.js) core(audits): Add more keywords to blocklist Dec 18, 2019
@patrickhulce
Copy link
Collaborator

we should consider moving this to our i18n pipeline

good idea! though I'm a little worried the translators might just make literal translations compared to what is commonplace on the web for links? then again our current setup isn't exactly super robust to check for that :)

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickhulce patrickhulce merged commit e689945 into GoogleChrome:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants