-
Notifications
You must be signed in to change notification settings - Fork 213
change pyo3 as optional dependency in native Python Parser #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looks largely good, but I'd like to change two things before merging:
- let's run something in CI to make sure the crate isn't broken without the new feature (at least it should build)
- can we call the new feature
py
orpython
? Just in case later we decide to change pyo3 to something else
cargo fmt
Done. Change to |
Codecov Report
@@ Coverage Diff @@
## main #598 +/- ##
==========================================
+ Coverage 94.73% 94.76% +0.03%
==========================================
Files 242 245 +3
Lines 24843 25038 +195
==========================================
+ Hits 23534 23728 +194
- Misses 1309 1310 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks for the contribution
@zsol great work on Python Parser. This makes it more accessible outside this project.
Summary
Native Rust parser has
pyo3
as a mandatory dependency. Since I am only interested in Python Parser, I want to change to optional dependency to reduce compile and build complexity. With the change,pyo3
is still included as a default feature thus everything is the same as before.Pyo3 related code changes (conversion) are segregated together.
Test Plan
The existing test plan should be sufficient since this is feature separation.