inference failure on nested `zip` iteration

[stakaz]

Hello, I was hitting the following problem: when using nested zip functions julia is somehow not able to generate fast code on the first run but on the second run the function becomes fast. An example is

using Statistics 
using BenchmarkTools 

f(X) = reweight((a for a ∈ X.A), 0.1)
g(X) = reweight((a * b for (a, b) ∈ zip(X.A, X.B)), 0.1)

@inline function reweight(A, ω)
    N = 0.0
    for (a,) ∈ zip(A)
        N += a
    end
    return N
end

N = 100
X = (A = rand(N), B = rand(N))

println("f")
@btime f($X)

println("g")
@btime g($X)
@code_warntype g(X)

Here, the first time @code_warntype is reporting some bad things but running the code again removes this and the function is much faster.

There is a discussion on discourse and I was suggested to submit an issue for this here.

julia> versioninfo()
Julia Version 1.1.0
Commit 80516ca202 (2019-01-21 21:24 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
  CPU: Intel(R) Pentium(R) CPU  N3530  @ 2.16GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, silvermont)

Please help me to find a solution for this as it really slows down my calculations considerable. Thanks.

[c42f]

I believe the root cause is that inference gives up on nested zip iterators:

julia> @code_warntype sum(x->x[1][1], zip(zip([1,2,3])))
Body::Any
1 ─ %1 = Base.add_sum::Core.Compiler.Const(Base.add_sum, false)
│   %2 = invoke Base.mapfoldl_impl(_2::Function, %1::Function, $(QuoteNode(NamedTuple()))::NamedTuple{(),Tuple{}}, _3::Base.Iterators.Zip{Tuple{Base.Iterators.Zip{Tuple{Array{Int64,1}}}}})::Any
└──      return %2

[adienes]

fixed in 1.11

julia> @code_warntype sum(x->x[1][1], zip(zip([1,2,3])))
MethodInstance for sum(::var"#2#3", ::Base.Iterators.Zip{Tuple{Base.Iterators.Zip{Tuple{Vector{Int64}}}}})
  from sum(f, a; kw...) @ Base reduce.jl:524
Arguments
  #self#::Core.Const(sum)
  f::Core.Const(var"#2#3"())
  a::Base.Iterators.Zip{Tuple{Base.Iterators.Zip{Tuple{Vector{Int64}}}}}
Body::Int64
1 ─ %1 = Base.:(var"#sum#277")::Core.Const(Base.var"#sum#277")
│   %2 = Core.NamedTuple()::Core.Const(NamedTuple())
│   %3 = Base.pairs(%2)::Core.Const(Base.Pairs{Symbol, Union{}, Tuple{}, @NamedTuple{}}())
│   %4 = (%1)(%3, #self#, f, a)::Int64
└──      return %4

also, I believe a duplicate of #51348