Skip to content

Remove support for logging multiple metrics together #16389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2023
Merged

Remove support for logging multiple metrics together #16389

merged 2 commits into from
Jan 17, 2023

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 17, 2023 •
edited by github-actions bot
Loading

What does this PR do?

Removes support for log("key", {"something": 123})

If the logger instance supports this, we suggest logging directly into it, instead of going through the self.log mechanism.

These logged keys couldn't be monitored by ModelCheckpoint or EarlyStopping.

The objective of this is to simplify the logging internals. As this is a very niche feature.

Does your PR introduce any breaking changes? If yes, please list them.

Removes the above.

cc @justusschock @awaelchli @carmocca @Blaizzy @Borda

@carmocca carmocca added refactor logging Related to the `LoggerConnector` and `log()` breaking change Includes a breaking change pl Generic label for PyTorch Lightning package labels Jan 17, 2023
@carmocca carmocca self-assigned this Jan 17, 2023
@carmocca carmocca force-pushed the lite/debug-log-dict branch from 70c4f18 to 8fa72ea Compare January 17, 2023 01:40
@carmocca carmocca marked this pull request as ready for review January 17, 2023 02:19
@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2023 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11) success ✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12) success ✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest) success ✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11) success ✅
pl-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.13) success ✅

These checks are required after the changes to src/pytorch_lightning/core/module.py, src/pytorch_lightning/trainer/connectors/logger_connector/result.py, src/pytorch_lightning/utilities/types.py, tests/tests_pytorch/callbacks/progress/test_tqdm_progress_bar.py, tests/tests_pytorch/core/test_metric_result_integration.py, tests/tests_pytorch/trainer/logging_/test_eval_loop_logging.py, tests/tests_pytorch/trainer/logging_/test_logger_connector.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success ✅

These checks are required after the changes to src/pytorch_lightning/core/module.py, src/pytorch_lightning/trainer/connectors/logger_connector/result.py, src/pytorch_lightning/utilities/types.py, tests/tests_pytorch/callbacks/progress/test_tqdm_progress_bar.py, tests/tests_pytorch/core/test_metric_result_integration.py, tests/tests_pytorch/trainer/logging_/test_eval_loop_logging.py, tests/tests_pytorch/trainer/logging_/test_logger_connector.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py.

🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success ✅

These checks are required after the changes to src/pytorch_lightning/core/module.py, src/pytorch_lightning/trainer/connectors/logger_connector/result.py, src/pytorch_lightning/utilities/types.py, tests/tests_pytorch/callbacks/progress/test_tqdm_progress_bar.py, tests/tests_pytorch/core/test_metric_result_integration.py, tests/tests_pytorch/trainer/logging_/test_eval_loop_logging.py, tests/tests_pytorch/trainer/logging_/test_logger_connector.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py.

🟢 pytorch_lightning: Azure IPU
Check ID Status
pytorch-lightning (IPUs) success ✅

These checks are required after the changes to src/pytorch_lightning/core/module.py, src/pytorch_lightning/trainer/connectors/logger_connector/result.py, src/pytorch_lightning/utilities/types.py, tests/tests_pytorch/callbacks/progress/test_tqdm_progress_bar.py, tests/tests_pytorch/core/test_metric_result_integration.py, tests/tests_pytorch/trainer/logging_/test_eval_loop_logging.py, tests/tests_pytorch/trainer/logging_/test_logger_connector.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py.

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅

These checks are required after the changes to src/pytorch_lightning/core/module.py, src/pytorch_lightning/trainer/connectors/logger_connector/result.py, src/pytorch_lightning/utilities/types.py, docs/source-pytorch/extensions/logging.rst, docs/source-pytorch/visualize/logging_intermediate.rst.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to src/pytorch_lightning/core/module.py, src/pytorch_lightning/trainer/connectors/logger_connector/result.py, src/pytorch_lightning/utilities/types.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, fabric, 3.7) success ✅
install-pkg (ubuntu-22.04, fabric, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.7) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.7) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (ubuntu-22.04, notset, 3.7) success ✅
install-pkg (ubuntu-22.04, notset, 3.10) success ✅
install-pkg (macOS-12, app, 3.7) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, fabric, 3.7) success ✅
install-pkg (macOS-12, fabric, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.7) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.7) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (macOS-12, notset, 3.7) success ✅
install-pkg (macOS-12, notset, 3.10) success ✅
install-pkg (windows-2022, app, 3.7) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, fabric, 3.7) success ✅
install-pkg (windows-2022, fabric, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.7) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.7) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅
install-pkg (windows-2022, notset, 3.7) success ✅
install-pkg (windows-2022, notset, 3.10) success ✅

These checks are required after the changes to src/pytorch_lightning/core/module.py, src/pytorch_lightning/trainer/connectors/logger_connector/result.py, src/pytorch_lightning/utilities/types.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

tchaton
tchaton approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Jan 17, 2023
@carmocca carmocca merged commit cafbc0c into lite/debug Jan 17, 2023
@carmocca carmocca deleted the lite/debug-log-dict branch January 17, 2023 12:35
carmocca added a commit that referenced this pull request Jan 17, 2023
@carmocca
Remove support for logging multiple metrics together (#16389)
f7a4b28
carmocca added a commit that referenced this pull request Jan 17, 2023
@carmocca
Remove support for logging multiple metrics together (#16389)
c54a290
carmocca added a commit that referenced this pull request Jan 17, 2023
@carmocca
Remove support for logging multiple metrics together (#16389)
4cdde91
Borda pushed a commit that referenced this pull request Jan 18, 2023
@carmocca @Borda
Remove support for logging multiple metrics together (#16389)
4358825
@carmocca carmocca added this to the 2.0 milestone Jan 19, 2023
carmocca added a commit that referenced this pull request Jan 19, 2023
@carmocca
Remove support for logging multiple metrics together (#16389)
4af28a2
carmocca added a commit that referenced this pull request Jan 19, 2023
@carmocca
Remove support for logging multiple metrics together (#16389)
0ac1f86
carmocca added a commit that referenced this pull request Jan 19, 2023
@carmocca
Remove support for logging multiple metrics together (#16389)
14f8586
lantiga pushed a commit that referenced this pull request Jan 19, 2023
@carmocca @lantiga
Remove support for logging multiple metrics together (#16389)
256199f
@carmocca carmocca mentioned this pull request Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton tchaton approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@justusschock justusschock Awaiting requested review from justusschock

@edenlightning edenlightning Awaiting requested review from edenlightning

@Borda Borda Awaiting requested review from Borda

Assignees

@carmocca carmocca

Labels
breaking change Includes a breaking change logging Related to the `LoggerConnector` and `log()` pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@carmocca @awaelchli @tchaton