Skip to content

[Bug Fix] Fix timer device #7939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

KB-Ding
Copy link
Contributor

@KB-Ding KB-Ding commented Jan 31, 2024

PR types

Bug fixes

PR changes

Others

Description

Fix timer device

fix timer device
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lugimzzz lugimzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (9a31322) 56.68% compared to head (1626272) 56.79%.
Report is 2 commits behind head on develop.

Files Patch % Lines
paddlenlp/trainer/trainer.py 71.42% 4 Missing ⚠️
paddlenlp/trainer/plugins/timer.py 85.71% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7939      +/-   ##
===========================================
+ Coverage    56.68%   56.79%   +0.11%     
===========================================
  Files          588      588              
  Lines        89358    89536     +178     
===========================================
+ Hits         50651    50853     +202     
+ Misses       38707    38683      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zjjlivein zjjlivein merged commit 44bfeb0 into PaddlePaddle:develop Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants