Fix PCL with QHull 2012 on non-debian platforms #852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upstream added libqhull_p.so in version 2012 which is compiled _with_ -Dqh_QHpointer and changed libqhull.so to use -Dqh_QHpointer=0. Only debian/ubuntu doesn't acknowledge this and still provides libqhull.so with -Dqh_QHpointer=1. Before this change PCL+QHULL_USE_STATIC=0 compiled with -Dqh_QHpointer, but always linked libqhull.so. As explained this is the wrong choice on qhull 2012 with non-debian systems. Closes PointCloudLibrary#410
Projects which depend on PCL could link to a different libqhull than the one used to build PCL. This can produce quite a headache with the qhull/qhull_p distinction and should therefore be forbidden.
|
Great investigation! I think the fix is quite elegant. I did some experiments on my Arch box and here are the results:
So from my side everything seems to be fine. |
jspricke
added a commit
that referenced
this pull request
Aug 19, 2014
Fix PCL with QHull 2012 on non-debian platforms
v4hn
added a commit
to v4hn/geometric_shapes
that referenced
this pull request
Mar 27, 2015
See PointCloudLibrary/pcl#852 for details on this bug.
v4hn
added a commit
to v4hn/geometric_shapes
that referenced
this pull request
Jun 15, 2016
See PointCloudLibrary/pcl#852 for details on this bug.
v4hn
added a commit
to moveit/geometric_shapes
that referenced
this pull request
Jun 15, 2016
See PointCloudLibrary/pcl#852 for details on this bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the commit messages & #410 for details