Skip to content

Add generic type overwrite to deepmerge.all #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

DanielMSchmidt
Copy link
Contributor

Hey,

Thank you for this great library, I just happened to have a case where deepmerge.all came in handy and I wanted to have the types set up right, so this is why I would need this change.

@TehShrike
Copy link
Owner

This makes sense to me.

In this pull request could you also add a line to https://github.com/KyleAMathews/deepmerge/blob/master/test/typescript.ts that fails the type checker without this addition?

@DanielMSchmidt
Copy link
Contributor Author

Oh, I have completely overlooked this one. Added it 👍

@TehShrike
Copy link
Owner

Whoops, looks like it's failing at the moment:

test/typescript.ts(55,1): error TS2322: Type 'object' is not assignable to type '{ wat: number; }'.
  Property 'wat' is missing in type '{}'.
test/typescript.ts(56,1): error TS2304: Cannot find name 'merged4'.

https://travis-ci.org/KyleAMathews/deepmerge/jobs/465025267

@DanielMSchmidt
Copy link
Contributor Author

Sorry for the extra feedback loop 🙈

@TehShrike TehShrike merged commit dcd8331 into TehShrike:master Jan 16, 2019
@TehShrike
Copy link
Owner

Published as 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants