Skip to content

Conversation

ArtskydJ
Copy link
Contributor

  • Clarify arrayMerge's arguments.
  • Fix clone heading level.

@TehShrike
Copy link
Owner

Looks good to me. I wonder if those comments inside concatMerge should be assertion comments with the =>, just to guarantee they're correct?

@ArtskydJ
Copy link
Contributor Author

ArtskydJ commented Nov 17, 2016

Like this?

destinationArray // => [1, 2, 3]
sourceArray // => [3, 2, 1]
options // => { arrayMerge: concatMerge }

@TehShrike
Copy link
Owner

Yeah, that should do it I think.

@ArtskydJ
Copy link
Contributor Author

Done.

@TehShrike TehShrike merged commit c8b04a9 into TehShrike:master Dec 3, 2016
@TehShrike
Copy link
Owner

Published as 1.3.1. Thanks!

@ArtskydJ ArtskydJ deleted the patch-1 branch December 5, 2016 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants