[Merged by Bors] - Fix use of arrays of Distributions #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torfjelde
approved these changes
May 18, 2021
Co-authored-by: Tor Erlend Fjelde <[email protected]>
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 18, 2021
This PR fixes #28 (comment) and allows to use arbitrary arrays of `Distribution`s. This was already allowed in the context implementations but prevented by a check in the code generated by the `@model` macro. Additionally, the PR replaces the hard-coded check with a `check_tilde_rhs` function which, IMO, makes the code a bit simpler and easier to read. Moreover, a bug in the `dot_assume` implementation for arrays of Distributions is fixed. Co-authored-by: David Widmann <[email protected]>
bors bot
pushed a commit
that referenced
this pull request
May 18, 2021
This PR extends the tests that were introduced in #245. Co-authored-by: David Widmann <[email protected]>
bors bot
pushed a commit
that referenced
this pull request
May 18, 2021
This PR extends the tests that were introduced in #245. Co-authored-by: David Widmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #28 (comment) and allows to use arbitrary arrays of
Distributions. This was already allowed in the context implementations but prevented by a check in the code generated by the@modelmacro.Additionally, the PR replaces the hard-coded check with a
check_tilde_rhsfunction which, IMO, makes the code a bit simpler and easier to read. Moreover, a bug in thedot_assumeimplementation for arrays of Distributions is fixed.