Adds new Permissions Policies #177
Conversation
- Attribution Reporting - Bluetooth - BrowsingTopics - DisplayCapture
…ission policy builders
- Hid - Identity Credentials - Idle Detection - Local Fonts - Otp Credentials - Publickey Credentials Create - Publickey Credentials Get - Screen Wake Lock - Serial - Speaker Selection - Storage Access - Web Share - Window Management - Xr Spatial Tracking
Adds Permissions Policy test to check for valid Permissions Policy with all options set to none.
There was a problem hiding this comment.
Thanks for this @Registeel! Just some minor questions - I feel bad about the comments, so if you were just copying them in manually don't worry about it, and I can do the updates 😅
I think the public API file unit test needs to be updated too (that's a new addition, sorry!)
...tyHeaders/Headers/PermissionsPolicy/AttributionReportingPermissionsPolicyDirectiveBuilder.cs
Outdated
Show resolved
Hide resolved
...SecurityHeaders/Headers/PermissionsPolicy/BrowsingTopicsPermissionsPolicyDirectiveBuilder.cs
Outdated
Show resolved
Hide resolved
|
👋 Hey @Registeel, just wanted to check in to see if you thought you would have a chance to finish off this PR soon? If not, I'm happy to take it to get it merged sooner rather than later, but didn't want to duplicate that work if you already have it in hand! 🙂 |
|
@andrewlock Sorry! Work has been nuts and kid activities just started up again. I can get that capped off for you this evening. |
|
No worries, don't feel any pressure, just wanted to check in! 😃 |
- Attribution Reporting - Bluetooth - Display Capture - HID Removes Browsing Topics feature as it is experimental Reverts version to 0.23.0
- Identity Credentials Get - Idle Detection - Local Fonts - OTP Credentials - Publickey Credentials Create - Publickey Credentials Get - Screen Wake Lock - Serial - Speaker Selection - Storage Access - Web Share - Window Management - XR Spatial Tracking
|
@andrewlock I have all the comments updated and pushed up. The only thing I'm kind of hung up on is the public API file unit test. I'm not sure what it's looking for. |
|
Nevermind! I think we are good to go on this one as long as it all looks good to you. |
|
Thanks @Registeel this looks great! |
Adds the following Permissions Policies: