Skip to content

Commit 34d63fa

Browse files
authored
Fix BigQueryDataTransferServiceHook.get_transfer_run() request parameter (#21293)
1 parent 471e368 commit 34d63fa

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

airflow/providers/google/cloud/hooks/bigquery_dts.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ def get_transfer_run(
260260
if self.location:
261261
project = f"{project}/locations/{self.location}"
262262

263-
name = "f{project}/transferConfigs/{transfer_config_id}/runs/{run_id}"
263+
name = f"{project}/transferConfigs/{transfer_config_id}/runs/{run_id}"
264264
return client.get_transfer_run(
265265
request={'name': name}, retry=retry, timeout=timeout, metadata=metadata or ()
266266
)

tests/providers/google/cloud/hooks/test_bigquery_dts.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@
4646
)
4747

4848
TRANSFER_CONFIG_ID = "id1234"
49+
RUN_ID = "id1234"
4950

5051

5152
class BigQueryDataTransferHookTestCase(unittest.TestCase):
@@ -106,3 +107,14 @@ def test_start_manual_transfer_runs(self, service_mock):
106107
retry=None,
107108
timeout=None,
108109
)
110+
111+
@mock.patch(
112+
"airflow.providers.google.cloud.hooks.bigquery_dts.DataTransferServiceClient.get_transfer_run"
113+
)
114+
def test_get_transfer_run(self, service_mock):
115+
self.hook.get_transfer_run(
116+
run_id=RUN_ID, transfer_config_id=TRANSFER_CONFIG_ID, project_id=PROJECT_ID
117+
)
118+
119+
name = f"projects/{PROJECT_ID}/transferConfigs/{TRANSFER_CONFIG_ID}/runs/{RUN_ID}"
120+
service_mock.assert_called_once_with(request=dict(name=name), metadata=(), retry=None, timeout=None)

0 commit comments

Comments
 (0)