[fix](arrow-flight-sql) Fix Arrow Flight bearer token cache evict after expired #41754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
yiguolei
reviewed
Oct 14, 2024
| @@ -82,6 +88,8 @@ public FlightTokenDetails load(String key) { | |||
| return new FlightTokenDetails(); | |||
| } | |||
| }); | |||
| this.cleanupExecutor = Executors.newScheduledThreadPool(1, new CustomThreadFactory("flight-token-cleanup")); | |||
There was a problem hiding this comment.
我们为什么不是再register connection的时候检查一下链接是否满了，主动淘汰呢？
There was a problem hiding this comment.
不好，因为链接没满，也希望可以淘汰过期的token，
- 这里淘汰的是 flight token，也就是 arrow flight server 的登陆凭证，不是flight链接，这个 token 预期是要有过期淘汰机制的，类似账户登陆后一段时间就要重新登陆。
- 淘汰 token 会同时淘汰 flight 链接，因为如果 token 淘汰了那 flight 链接也就不会再访问了，用户 show processlist 看到 arrow flight 链接一直没有释放会有疑问。
- 默认 token 过期时间是 3天，flight/mysql 链接过期时间要更短，也就是一次登陆（拿到token）可以多次创建链接，所以不能在 flight 链接过期淘汰的同时淘汰 token。
yiguolei
approved these changes
Oct 16, 2024
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
xinyiZzz
added a commit
to xinyiZzz/incubator-doris
that referenced
this pull request
Oct 22, 2024
…er expired (apache#41754) Guava LoadingCache expiration check is performed when the cache is accessed, not immediately when the expiration time is reached. So manually call the cleanUp method regularly to clean up expired cache items.
xinyiZzz
added a commit
to xinyiZzz/incubator-doris
that referenced
this pull request
Nov 11, 2024
…er expired (apache#41754) Guava LoadingCache expiration check is performed when the cache is accessed, not immediately when the expiration time is reached. So manually call the cleanUp method regularly to clean up expired cache items.
xinyiZzz
added a commit
to xinyiZzz/incubator-doris
that referenced
this pull request
Nov 18, 2024
…er expired (apache#41754) Guava LoadingCache expiration check is performed when the cache is accessed, not immediately when the expiration time is reached. So manually call the cleanUp method regularly to clean up expired cache items.
This was referenced Nov 18, 2024
dataroaring
pushed a commit
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guava LoadingCache expiration check is performed when the cache is accessed, not immediately when the expiration time is reached.
So manually call the cleanUp method regularly to clean up expired cache items.