-
Notifications
You must be signed in to change notification settings - Fork 19.8k
fix:improve PictorialBarSeriesOption #17155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your contribution! |
Ovilia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update PR description to let us know what this PR does and why it's necessary.
|
The PR description is completed |
|
I check the code and the following series don't have
|
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Tree based data source (
|
Brief Information
This pull request is in the type of:
What does this PR do?
Let the interface PictorialBarSeriesOption extends the interface SeriesEncodeOptionMixin .
Fixed issues
No issues.
Details
Before: What was the problem?
The interface PictorialBarSeriesOption don't extends interface SeriesEncodeOptionMixin.
But PictorialBar supports the config
encodeas document describled.So,this PR was produced to improve the definition of PictorialBar.
After: How is it fixed in this PR?
Let the interface PictorialBarSeriesOption extends interface SeriesEncodeOptionMixin .
Misc
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information