KAFKA-18004: Use 3.8 to run zk service for e2e #17790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Nov 13, 2024
| @@ -44,7 +44,7 @@ class ZookeeperService(KafkaPathResolverMixin, Service): | |||
| } | |||
|
|
|||
| def __init__(self, context, num_nodes, zk_sasl = False, zk_client_port = True, zk_client_secure_port = False, | |||
| zk_tls_encrypt_only = False, version=DEV_BRANCH): | |||
There was a problem hiding this comment.
We need to replace all dev by 3.8 for this file
There was a problem hiding this comment.
Hi @chia7712, I replace all dev with 3.8 in this file and add a comment. Could you take a look again when you have time? Thank you.
Signed-off-by: PoAn Yang <[email protected]>
8e67286 to
b55dd15
Compare
chiacyu
pushed a commit
to chiacyu/kafka
that referenced
this pull request
Nov 30, 2024
…nd tests (apache#17790) We plan to remove all ZooKeeper-related code in version 4.0. However, some old brokers in the end-to-end tests still require ZooKeeper service, so we need to run the ZooKeeper service using the 3.x release instead of the dev branch. Since version 3.9 is not available in the https://s3-us-west-2.amazonaws.com/kafka-packages repo, we can use version 3.8 for now. Reviewers: Chia-Ping Tsai <[email protected]>
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
…nd tests (apache#17790) We plan to remove all ZooKeeper-related code in version 4.0. However, some old brokers in the end-to-end tests still require ZooKeeper service, so we need to run the ZooKeeper service using the 3.x release instead of the dev branch. Since version 3.9 is not available in the https://s3-us-west-2.amazonaws.com/kafka-packages repo, we can use version 3.8 for now. Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We plan to remove all ZooKeeper-related code in version 4.0. However, some old brokers in the end-to-end tests still require ZooKeeper service, so we need to run the ZooKeeper service using the 3.x release instead of the dev branch.
Since version 3.9 is not available in the https://s3-us-west-2.amazonaws.com/kafka-packages repo, we can use version 3.8 for now.
Test with #17768. Failed case with version v2.1.1, v.2.2.2, and v2.3.1 will be fixed in https://issues.apache.org/jira/browse/KAFKA-17888.
Committer Checklist (excluded from commit message)