[fix][test] Cleanup resources if starting PulsarService fails in PulsarTestContext #21467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
approved these changes
Oct 30, 2023
Codecov Report
@@ Coverage Diff @@
## master #21467 +/- ##
============================================
- Coverage 73.29% 73.25% -0.05%
- Complexity 32505 32599 +94
============================================
Files 1890 1890
Lines 140381 140381
Branches 15425 15425
============================================
- Hits 102898 102839 -59
- Misses 29405 29463 +58
- Partials 8078 8079 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
tisonkun
approved these changes
Oct 30, 2023
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Jun 20, 2025
…arTestContext (apache#21467) (cherry picked from commit a14af46)
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 21, 2025
…arTestContext (apache#21467) (cherry picked from commit a14af46) (cherry picked from commit 7d75e51)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 24, 2025
…arTestContext (apache#21467) (cherry picked from commit a14af46) (cherry picked from commit 7d75e51)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PulsarTestContext leaks resources when starting PulsarService fails. This happens at least in ManagedLedgerCompressionTest.
Modifications
Improve logic when PulsarService.start fails. Improve logic to chain closing of another PulsarTestContext.
Documentation
docdoc-requireddoc-not-neededdoc-complete