Skip to content

Conversation

thetumbled
Copy link
Member

@thetumbled thetumbled commented Mar 12, 2025

Motivation

#24020 support configure the producer of retry/dead-letter topic, but it don't take effect.

Modifications

Make sure the config is used.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: thetumbled#73

@thetumbled thetumbled requested review from dao-jun and coderzc and removed request for dao-jun March 12, 2025 07:25
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 12, 2025
@thetumbled thetumbled self-assigned this Mar 12, 2025
@thetumbled thetumbled requested a review from crossoverJie March 13, 2025 07:30
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.16%. Comparing base (bbc6224) to head (4530b6b).
Report is 964 commits behind head on master.

Files with missing lines Patch % Lines
...va/org/apache/pulsar/client/impl/ConsumerImpl.java 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24071      +/-   ##
============================================
+ Coverage     73.57%   74.16%   +0.58%     
+ Complexity    32624     2379   -30245     
============================================
  Files          1877     1863      -14     
  Lines        139502   144297    +4795     
  Branches      15299    16459    +1160     
============================================
+ Hits         102638   107015    +4377     
+ Misses        28908    28828      -80     
- Partials       7956     8454     +498     
Flag Coverage Δ
inttests 26.94% <66.66%> (+2.35%) ⬆️
systests 23.20% <0.00%> (-1.12%) ⬇️
unittests 73.65% <66.66%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...va/org/apache/pulsar/client/impl/ProducerImpl.java 84.16% <ø> (+0.56%) ⬆️
...va/org/apache/pulsar/client/impl/ConsumerImpl.java 79.16% <66.66%> (+1.58%) ⬆️

... and 1062 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thetumbled thetumbled added release/4.0.4 type/bug The PR fixed a bug or issue reported a bug PIP labels Mar 14, 2025
@thetumbled thetumbled merged commit e517705 into apache:master Mar 14, 2025
53 of 54 checks passed
lhotari pushed a commit that referenced this pull request Mar 17, 2025
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 29, 2025
…ake effect. (apache#24071)

(cherry picked from commit e517705)
(cherry picked from commit 792f62a)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 31, 2025
…ake effect. (apache#24071)

(cherry picked from commit e517705)
(cherry picked from commit 792f62a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client cherry-picked/branch-4.0 doc-not-needed Your PR changes do not impact docs PIP release/4.0.4 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants