[fix][broker] Fix some problems in calculate totalAvailableBookies in method getExcludedBookiesWithIsolationGroups when some bookies belongs to multiple isolation groups. #24091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… method getExcludedBookiesWithIsolationGroups
lhotari
approved these changes
Mar 19, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24091 +/- ##
============================================
+ Coverage 73.57% 74.24% +0.67%
+ Complexity 32624 32445 -179
============================================
Files 1877 1863 -14
Lines 139502 144315 +4813
Branches 15299 16460 +1161
============================================
+ Hits 102638 107150 +4512
+ Misses 28908 28706 -202
- Partials 7956 8459 +503
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
poorbarcode
pushed a commit
to poorbarcode/pulsar
that referenced
this pull request
Apr 15, 2025
… method getExcludedBookiesWithIsolationGroups when some bookies belongs to multiple isolation groups. (apache#24091)
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Apr 22, 2025
… method getExcludedBookiesWithIsolationGroups when some bookies belongs to multiple isolation groups. (apache#24091) (cherry picked from commit 556024d)
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 24, 2025
… method getExcludedBookiesWithIsolationGroups when some bookies belongs to multiple isolation groups. (apache#24091) (cherry picked from commit 556024d) (cherry picked from commit 6052e72)
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 24, 2025
… method getExcludedBookiesWithIsolationGroups when some bookies belongs to multiple isolation groups. (apache#24091) (cherry picked from commit 556024d) (cherry picked from commit 6052e72)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 25, 2025
… method getExcludedBookiesWithIsolationGroups when some bookies belongs to multiple isolation groups. (apache#24091) (cherry picked from commit 556024d) (cherry picked from commit 6052e72)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 27, 2025
… method getExcludedBookiesWithIsolationGroups when some bookies belongs to multiple isolation groups. (apache#24091) (cherry picked from commit 556024d) (cherry picked from commit 6052e72)
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 30, 2025
… method getExcludedBookiesWithIsolationGroups when some bookies belongs to multiple isolation groups. (apache#24091) (cherry picked from commit 556024d) (cherry picked from commit 6052e72)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 2, 2025
… method getExcludedBookiesWithIsolationGroups when some bookies belongs to multiple isolation groups. (apache#24091) (cherry picked from commit 556024d) (cherry picked from commit 6052e72)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 2, 2025
… method getExcludedBookiesWithIsolationGroups when some bookies belongs to multiple isolation groups. (apache#24091) (cherry picked from commit 556024d) (cherry picked from commit 5a4aed5)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 6, 2025
… method getExcludedBookiesWithIsolationGroups when some bookies belongs to multiple isolation groups. (apache#24091) (cherry picked from commit 556024d) (cherry picked from commit 5a4aed5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the values of
totalAvailableBookiesInPrimaryGroupandtotalAvailableBookiesFromPrimaryAndSecondarymay not be accurate because there may be repeated accumulation when some bookies belongs to multiple isolation groups.For example: There are 3 bookies in total and has 3 group, the distribution is as follows
Group1: bk1
Group2: bk2,bk3
Group3: bk1
When
primaryIsolationGroupcontains Group1 and Group3,secondaryIsolationGroupcontains Group2, when execute the methodgetExcludedBookiesWithIsolationGroups(2, groups[primaryIsolationGroup,secondaryIsolationGroup]). The correct return value should be empty but current return bk2 and bk3.The calculation of
totalAvailableBookiesFromPrimaryAndSecondaryhas similar problems.Modifications
Fix the calculation logic of
totalAvailableBookiesInPrimaryGroupandtotalAvailableBookiesFromPrimaryAndSecondary.Documentation
docdoc-requireddoc-not-neededdoc-complete