Skip to content

Conversation

shibd
Copy link
Member

@shibd shibd commented Mar 25, 2025

Motivation

If ClientCredentialsFlow initialization fails, the exchanger might be null, which could lead to a NullPointerException when closing.

2025-03-11 12:26:43,050 WARN  org.apache.pulsar.client.impl.PulsarClientImpl               [] - Failed to close authentication
java.io.IOException: java.lang.NullPointerException: Cannot invoke "org.apache.pulsar.client.impl.auth.oauth2.protocol.ClientCredentialsExchanger.close()" because "this.exchanger" is null

Modifications

  • Add null check.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@shibd
Copy link
Member Author

shibd commented Mar 25, 2025

/pulsarbot rerun-failure-checks

@shibd shibd requested review from nodece, dao-jun and poorbarcode March 26, 2025 00:10
@shibd shibd merged commit b402985 into apache:master Mar 26, 2025
59 of 60 checks passed
shibd added a commit that referenced this pull request Mar 26, 2025
shibd added a commit that referenced this pull request Mar 26, 2025
shibd added a commit that referenced this pull request Mar 26, 2025
nodece pushed a commit to nodece/pulsar that referenced this pull request Mar 27, 2025
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 27, 2025
…ntialsFlow (apache#24123)

(cherry picked from commit b402985)
(cherry picked from commit 8d9ae13)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 28, 2025
…ntialsFlow (apache#24123)

(cherry picked from commit b402985)
(cherry picked from commit 8d9ae13)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 28, 2025
…ntialsFlow (apache#24123)

(cherry picked from commit b402985)
(cherry picked from commit 38b471c)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 29, 2025
…ntialsFlow (apache#24123)

(cherry picked from commit b402985)
(cherry picked from commit 38b471c)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 31, 2025
…ntialsFlow (apache#24123)

(cherry picked from commit b402985)
(cherry picked from commit 38b471c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants