[fix][test] Fix flaky BrokerServiceChaosTest.testFetchPartitionedTopicMetadataWithCacheRefresh #24161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zixuan Liu <[email protected]>
...rc/test/java/org/apache/pulsar/broker/service/CanReconnectZKClientPulsarServiceBaseTest.java
Show resolved
Hide resolved
lhotari
approved these changes
Apr 8, 2025
heesung-sn
approved these changes
Apr 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24161 +/- ##
============================================
+ Coverage 73.57% 74.20% +0.63%
+ Complexity 32624 32116 -508
============================================
Files 1877 1864 -13
Lines 139502 144470 +4968
Branches 15299 16483 +1184
============================================
+ Hits 102638 107204 +4566
+ Misses 28908 28798 -110
- Partials 7956 8468 +512
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Technoboy-
pushed a commit
that referenced
this pull request
Apr 9, 2025
…cMetadataWithCacheRefresh (#24161) Signed-off-by: Zixuan Liu <[email protected]> Co-authored-by: Lari Hotari <[email protected]>
lhotari
added a commit
that referenced
this pull request
Apr 9, 2025
…cMetadataWithCacheRefresh (#24161) Signed-off-by: Zixuan Liu <[email protected]> Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit 9bcad7c)
lhotari
added a commit
that referenced
this pull request
Apr 9, 2025
…cMetadataWithCacheRefresh (#24161) Signed-off-by: Zixuan Liu <[email protected]> Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit 9bcad7c)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 11, 2025
…cMetadataWithCacheRefresh (apache#24161) Signed-off-by: Zixuan Liu <[email protected]> Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit 9bcad7c) (cherry picked from commit 59a2218)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 15, 2025
…cMetadataWithCacheRefresh (apache#24161) Signed-off-by: Zixuan Liu <[email protected]> Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit 9bcad7c) (cherry picked from commit 59a2218)
poorbarcode
pushed a commit
to poorbarcode/pulsar
that referenced
this pull request
Apr 15, 2025
…cMetadataWithCacheRefresh (apache#24161) Signed-off-by: Zixuan Liu <[email protected]> Co-authored-by: Lari Hotari <[email protected]>
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 15, 2025
…cMetadataWithCacheRefresh (apache#24161) Signed-off-by: Zixuan Liu <[email protected]> Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit 0634170)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 16, 2025
…cMetadataWithCacheRefresh (apache#24161) Signed-off-by: Zixuan Liu <[email protected]> Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit 0634170)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 16, 2025
…cMetadataWithCacheRefresh (apache#24161) Signed-off-by: Zixuan Liu <[email protected]> Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit 0634170)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 16, 2025
…cMetadataWithCacheRefresh (apache#24161) Signed-off-by: Zixuan Liu <[email protected]> Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit 0634170)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 16, 2025
…cMetadataWithCacheRefresh (apache#24161) Signed-off-by: Zixuan Liu <[email protected]> Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit 0634170)
nodece
added a commit
to nodece/pulsar
that referenced
this pull request
Apr 22, 2025
…cMetadataWithCacheRefresh (apache#24161) Signed-off-by: Zixuan Liu <[email protected]> Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit 9bcad7c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24160
Motivation
stopLocalMetadataStoreAlwaysReconnectshould wait for the zk to reconnect.Modifications
Listen for metadata store session events, and upon invoking
stopLocalMetadataStoreAlwaysReconnect, wait until aReconnectedis received before proceeding."Documentation
docdoc-requireddoc-not-neededdoc-complete