[fix][test] Fix resource leaks in ProxyTest and fix invalid tests #24204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heesung-sn
approved these changes
Apr 23, 2025
dao-jun
approved these changes
Apr 24, 2025
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 25, 2025
…ache#24204) (cherry picked from commit a3b31ff) (cherry picked from commit 0af42b1)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 27, 2025
…ache#24204) (cherry picked from commit a3b31ff) (cherry picked from commit 0af42b1)
manas-ctds
added a commit
to datastax/pulsar
that referenced
this pull request
Apr 28, 2025
…ests (apache#24204)" This reverts commit 8d05fe7.
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 30, 2025
…ache#24204) (cherry picked from commit a3b31ff) (cherry picked from commit 0af42b1)
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 1, 2025
…ache#24204) (cherry picked from commit a3b31ff) (cherry picked from commit 0af42b1)
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 1, 2025
…ache#24204) (cherry picked from commit a3b31ff) (cherry picked from commit 0af42b1)
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 1, 2025
…ache#24204) (cherry picked from commit a3b31ff) (cherry picked from commit 0af42b1)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 2, 2025
…ache#24204) (cherry picked from commit a3b31ff) (cherry picked from commit 0af42b1)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 2, 2025
…ache#24204) (cherry picked from commit a3b31ff) (cherry picked from commit bacd199)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 6, 2025
…ache#24204) (cherry picked from commit a3b31ff) (cherry picked from commit bacd199)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 28, 2025
…ache#24204) (cherry picked from commit a3b31ff)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ProxyTest and derived ProxyDisableZeroCopyTest leak a lot of resources.
In addition to this, the test
testGetPartitionedMetadataErrorCodedoesn't pass without a retry. There are conflicting tests that expect differentallowAutoTopicCreationTypeanddefaultNumPartitionssettings.Modifications
invocationCount = 100fortestRegexSubscriptionWithTopicDiscoveryallowAutoTopicCreationTypeanddefaultNumPartitionsconfig conflictsDocumentation
docdoc-requireddoc-not-neededdoc-complete