-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][test] Fix flaky ManagedCursorTest.testSkipEntriesWithIndividualDeletedMessages #24244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lhotari
merged 1 commit into
apache:master
from
nodece:fix-ManagedCursorTest.testSkipEntriesWithIndividualDeletedMessages
May 7, 2025
Merged
[fix][test] Fix flaky ManagedCursorTest.testSkipEntriesWithIndividualDeletedMessages #24244
lhotari
merged 1 commit into
apache:master
from
nodece:fix-ManagedCursorTest.testSkipEntriesWithIndividualDeletedMessages
May 7, 2025
+21
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DeletedMessages Signed-off-by: Zixuan Liu <[email protected]>
2 tasks
pdolif
reviewed
May 4, 2025
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java
Show resolved
Hide resolved
lhotari
approved these changes
May 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing @nodece
lhotari
pushed a commit
that referenced
this pull request
May 9, 2025
…DeletedMessages (#24244) Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 06341fc)
lhotari
pushed a commit
that referenced
this pull request
May 9, 2025
…DeletedMessages (#24244) Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 06341fc)
lhotari
pushed a commit
that referenced
this pull request
May 9, 2025
…DeletedMessages (#24244) Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 06341fc)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
…DeletedMessages (apache#24244) Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 06341fc) (cherry picked from commit eec11ec)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
…DeletedMessages (apache#24244) Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 06341fc) (cherry picked from commit 72def52)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
…DeletedMessages (apache#24244) Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 06341fc) (cherry picked from commit eec11ec)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
…DeletedMessages (apache#24244) Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 06341fc) (cherry picked from commit 72def52)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 15, 2025
…DeletedMessages (apache#24244) Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 06341fc) (cherry picked from commit 72def52)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 15, 2025
…DeletedMessages (apache#24244) Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 06341fc) (cherry picked from commit 72def52)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2025
…DeletedMessages (apache#24244) Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 06341fc) (cherry picked from commit 72def52)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 18, 2025
…DeletedMessages (apache#24244) Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 06341fc) (cherry picked from commit eec11ec)
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
May 28, 2025
…DeletedMessages (apache#24244) Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 06341fc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.12
release/3.3.7
release/4.0.5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #24244
Motivation
A new ledger will be created once the previous one has reached the configured
maxEntriesPerLedger
limit (set to 5). However, if the ledger does not roll over as expected due to timing.Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete