Skip to content

Conversation

nodece
Copy link
Member

@nodece nodece commented May 4, 2025

Fix #24244

Motivation

A new ledger will be created once the previous one has reached the configured maxEntriesPerLedger limit (set to 5). However, if the ledger does not roll over as expected due to timing.

Modifications

  • Added logic to explicitly wait until a new ledger is created after reaching the max entries per ledger.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@nodece nodece requested review from pdolif, lhotari and dao-jun and removed request for pdolif May 6, 2025 04:04
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing @nodece

@lhotari lhotari merged commit 06341fc into apache:master May 7, 2025
55 of 56 checks passed
lhotari pushed a commit that referenced this pull request May 9, 2025
…DeletedMessages (#24244)

Signed-off-by: Zixuan Liu <[email protected]>
(cherry picked from commit 06341fc)
lhotari pushed a commit that referenced this pull request May 9, 2025
…DeletedMessages (#24244)

Signed-off-by: Zixuan Liu <[email protected]>
(cherry picked from commit 06341fc)
lhotari pushed a commit that referenced this pull request May 9, 2025
…DeletedMessages (#24244)

Signed-off-by: Zixuan Liu <[email protected]>
(cherry picked from commit 06341fc)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
…DeletedMessages (apache#24244)

Signed-off-by: Zixuan Liu <[email protected]>
(cherry picked from commit 06341fc)
(cherry picked from commit eec11ec)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
…DeletedMessages (apache#24244)

Signed-off-by: Zixuan Liu <[email protected]>
(cherry picked from commit 06341fc)
(cherry picked from commit 72def52)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
…DeletedMessages (apache#24244)

Signed-off-by: Zixuan Liu <[email protected]>
(cherry picked from commit 06341fc)
(cherry picked from commit eec11ec)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
…DeletedMessages (apache#24244)

Signed-off-by: Zixuan Liu <[email protected]>
(cherry picked from commit 06341fc)
(cherry picked from commit 72def52)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 15, 2025
…DeletedMessages (apache#24244)

Signed-off-by: Zixuan Liu <[email protected]>
(cherry picked from commit 06341fc)
(cherry picked from commit 72def52)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 15, 2025
…DeletedMessages (apache#24244)

Signed-off-by: Zixuan Liu <[email protected]>
(cherry picked from commit 06341fc)
(cherry picked from commit 72def52)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 16, 2025
…DeletedMessages (apache#24244)

Signed-off-by: Zixuan Liu <[email protected]>
(cherry picked from commit 06341fc)
(cherry picked from commit 72def52)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 18, 2025
…DeletedMessages (apache#24244)

Signed-off-by: Zixuan Liu <[email protected]>
(cherry picked from commit 06341fc)
(cherry picked from commit eec11ec)
nodece added a commit to ascentstream/pulsar that referenced this pull request May 28, 2025
…DeletedMessages (apache#24244)

Signed-off-by: Zixuan Liu <[email protected]>
(cherry picked from commit 06341fc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants