Skip to content

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented May 5, 2025

Motivation

Error Prone was upgraded in #24242. The upgrade broke the configuration. It would be useful to be able to use errorprone for static code analysis since it detects some issues that SpotBugs doesn't detect.

Modifications

  • pass --should-stop=ifError=FLOW" compiler argument which is required after errorprone 2.34.0
  • add instructions to use jspecify nullness annotations for Lombok when enabling errorprone
  • add required dependencies to compile will temporary Lombok config for errorprone analysis

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.1.0 milestone May 5, 2025
@lhotari lhotari requested review from nodece, dao-jun and heesung-sn May 5, 2025 07:21
@lhotari lhotari self-assigned this May 5, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.22%. Comparing base (bbc6224) to head (3674312).
Report is 1068 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24246      +/-   ##
============================================
+ Coverage     73.57%   74.22%   +0.65%     
+ Complexity    32624    32574      -50     
============================================
  Files          1877     1866      -11     
  Lines        139502   144976    +5474     
  Branches      15299    16561    +1262     
============================================
+ Hits         102638   107610    +4972     
+ Misses        28908    28840      -68     
- Partials       7956     8526     +570     
Flag Coverage Δ
inttests 26.87% <ø> (+2.29%) ⬆️
systests 23.32% <ø> (-1.00%) ⬇️
unittests 73.70% <ø> (+0.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1077 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari merged commit 72f7126 into apache:master May 5, 2025
52 of 53 checks passed
lhotari added a commit that referenced this pull request May 5, 2025
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 8, 2025
(cherry picked from commit 72f7126)
(cherry picked from commit ee4b7ca)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 8, 2025
(cherry picked from commit 72f7126)
(cherry picked from commit ee4b7ca)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
(cherry picked from commit 72f7126)
(cherry picked from commit ee4b7ca)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants