-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][test] Fix flaky ManagedCursorTest.testLastActiveAfterResetCursor and disable failing SchemaTest #24261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lhotari
merged 3 commits into
apache:master
from
lhotari:lh-fix-flaky-managedcursortest-testLastActiveAfterResetCursor
May 7, 2025
Merged
[fix][test] Fix flaky ManagedCursorTest.testLastActiveAfterResetCursor and disable failing SchemaTest #24261
lhotari
merged 3 commits into
apache:master
from
lhotari:lh-fix-flaky-managedcursortest-testLastActiveAfterResetCursor
May 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
nodece
approved these changes
May 7, 2025
thetumbled
approved these changes
May 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
dao-jun
approved these changes
May 7, 2025
3a6051c
to
04cf6db
Compare
15 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24261 +/- ##
============================================
+ Coverage 73.57% 74.23% +0.65%
+ Complexity 32624 32593 -31
============================================
Files 1877 1866 -11
Lines 139502 145040 +5538
Branches 15299 16577 +1278
============================================
+ Hits 102638 107664 +5026
+ Misses 28908 28850 -58
- Partials 7956 8526 +570
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
…r and disable failing SchemaTest (apache#24261) (cherry picked from commit 616c3a1) (cherry picked from commit 4e2047b)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
…r and disable failing SchemaTest (apache#24261) (cherry picked from commit 616c3a1) (cherry picked from commit 6eb7f7b)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
…r and disable failing SchemaTest (apache#24261) (cherry picked from commit 616c3a1) (cherry picked from commit 4e2047b)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
…r and disable failing SchemaTest (apache#24261) (cherry picked from commit 616c3a1) (cherry picked from commit 6eb7f7b)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 15, 2025
…r and disable failing SchemaTest (apache#24261) (cherry picked from commit 616c3a1) (cherry picked from commit 6eb7f7b)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 15, 2025
…r and disable failing SchemaTest (apache#24261) (cherry picked from commit 616c3a1) (cherry picked from commit 6eb7f7b)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2025
…r and disable failing SchemaTest (apache#24261) (cherry picked from commit 616c3a1) (cherry picked from commit 6eb7f7b)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2025
…r and disable failing SchemaTest (apache#24261) (cherry picked from commit 616c3a1) (cherry picked from commit 6eb7f7b)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 18, 2025
…r and disable failing SchemaTest (apache#24261) (cherry picked from commit 616c3a1) (cherry picked from commit 4e2047b)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 28, 2025
…r and disable failing SchemaTest (apache#24261) (cherry picked from commit 616c3a1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.12
release/3.3.7
release/4.0.5
type/flaky-tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After upgrading Mockito to 5.17, the test ManagedCursorTest.testLastActiveAfterResetCursor is very flaky.
There are two problems:
In addition, Pulsar CI is currently blocked since SchemaTest.testPendingQueueSizeIfIncompatible fails consistently. This issue is reported as #24262. To unblock Pulsar CI, the change is included in this PR.
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete