Skip to content

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented May 7, 2025

Motivation

As a preparation for JDK 25 LTS version, Pulsar build should allow running with JDK 24 and with JDK 25 once it becomes available so that we can start fixing the different compatibility issues.

One of the already detected issues is that the Security Manager has been removed in JDK 24 with "JEP 486: Permanently Disable the Security Manager". This breaks at least tiered storage since it uses Hadoop libraries which depend on Security Manager (issue: HDFS-17778). There are also failing tests in Pulsar IO RabbitMQ connector which use Qpid libraries which require Security Manager features.

Modifications

  • change enforcer plugin config to allow building with JDK 24 and JDK 25 in addition to JDK 17 and JDK 24.
  • add required JVM arguments for JDK 24+
  • fix previous issue where Pulsar CI Flaky tests aren't built and run with JDK 21 by default
  • Add JDK 24 and JDK 25 choices for triggered Pulsar CI and Pulsar CI Flaky GitHub Actions workflows
  • Run Shade integration tests with JDK 24 too
  • Fix issue in building the Docker image for JDK 24

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.1.0 milestone May 7, 2025
@lhotari lhotari self-assigned this May 7, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 7, 2025
@lhotari lhotari force-pushed the lh-allow-jdk-24-25-building-and-testing branch from b0106d8 to 9999cd5 Compare May 7, 2025 13:20
Copy link
Member

@dao-jun dao-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goooood job!

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.15%. Comparing base (bbc6224) to head (d5e7121).
Report is 1085 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24268      +/-   ##
============================================
+ Coverage     73.57%   74.15%   +0.57%     
+ Complexity    32624    32565      -59     
============================================
  Files          1877     1866      -11     
  Lines        139502   145040    +5538     
  Branches      15299    16577    +1278     
============================================
+ Hits         102638   107552    +4914     
- Misses        28908    28940      +32     
- Partials       7956     8548     +592     
Flag Coverage Δ
inttests 26.72% <ø> (+2.13%) ⬆️
systests 23.28% <ø> (-1.04%) ⬇️
unittests 73.64% <ø> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1083 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari merged commit 5e5bd14 into apache:master May 7, 2025
54 checks passed
lhotari added a commit that referenced this pull request May 9, 2025
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
…ing JDK 25 LTS (apache#24268)

(cherry picked from commit 5e5bd14)
(cherry picked from commit 01864fc)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
…ing JDK 25 LTS (apache#24268)

(cherry picked from commit 5e5bd14)
(cherry picked from commit 01864fc)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 18, 2025
…ing JDK 25 LTS (apache#24268)

(cherry picked from commit 5e5bd14)
(cherry picked from commit 01864fc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants