-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve][build] Allow building and running tests on JDK 24 and upcoming JDK 25 LTS #24268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lhotari
merged 7 commits into
apache:master
from
lhotari:lh-allow-jdk-24-25-building-and-testing
May 7, 2025
Merged
[improve][build] Allow building and running tests on JDK 24 and upcoming JDK 25 LTS #24268
lhotari
merged 7 commits into
apache:master
from
lhotari:lh-allow-jdk-24-25-building-and-testing
May 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0106d8
to
9999cd5
Compare
dao-jun
approved these changes
May 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goooood job!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24268 +/- ##
============================================
+ Coverage 73.57% 74.15% +0.57%
+ Complexity 32624 32565 -59
============================================
Files 1877 1866 -11
Lines 139502 145040 +5538
Branches 15299 16577 +1278
============================================
+ Hits 102638 107552 +4914
- Misses 28908 28940 +32
- Partials 7956 8548 +592
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
…ing JDK 25 LTS (apache#24268) (cherry picked from commit 5e5bd14) (cherry picked from commit 01864fc)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
…ing JDK 25 LTS (apache#24268) (cherry picked from commit 5e5bd14) (cherry picked from commit 01864fc)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 18, 2025
…ing JDK 25 LTS (apache#24268) (cherry picked from commit 5e5bd14) (cherry picked from commit 01864fc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/build
area/ci
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/4.0.5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As a preparation for JDK 25 LTS version, Pulsar build should allow running with JDK 24 and with JDK 25 once it becomes available so that we can start fixing the different compatibility issues.
One of the already detected issues is that the Security Manager has been removed in JDK 24 with "JEP 486: Permanently Disable the Security Manager". This breaks at least tiered storage since it uses Hadoop libraries which depend on Security Manager (issue: HDFS-17778). There are also failing tests in Pulsar IO RabbitMQ connector which use Qpid libraries which require Security Manager features.
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete