-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[cleanup][test] Remove unused parameter from deleteNamespaceWithRetry method in MockedPulsarServiceBaseTest #24283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… method in MockedPulsarServiceBaseTest
lhotari
approved these changes
May 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @pdolif
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24283 +/- ##
============================================
+ Coverage 73.57% 74.18% +0.61%
+ Complexity 32624 32583 -41
============================================
Files 1877 1866 -11
Lines 139502 145054 +5552
Branches 15299 16580 +1281
============================================
+ Hits 102638 107612 +4974
- Misses 28908 28913 +5
- Partials 7956 8529 +573
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
… method in MockedPulsarServiceBaseTest (apache#24283) (cherry picked from commit 63d35d1) (cherry picked from commit b63f685)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
… method in MockedPulsarServiceBaseTest (apache#24283) (cherry picked from commit 63d35d1) (cherry picked from commit e5d309c)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
… method in MockedPulsarServiceBaseTest (apache#24283) (cherry picked from commit 63d35d1) (cherry picked from commit b63f685)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
… method in MockedPulsarServiceBaseTest (apache#24283) (cherry picked from commit 63d35d1) (cherry picked from commit b63f685)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
… method in MockedPulsarServiceBaseTest (apache#24283) (cherry picked from commit 63d35d1) (cherry picked from commit e5d309c)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
… method in MockedPulsarServiceBaseTest (apache#24283) (cherry picked from commit 63d35d1) (cherry picked from commit e5d309c)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 15, 2025
… method in MockedPulsarServiceBaseTest (apache#24283) (cherry picked from commit 63d35d1) (cherry picked from commit e5d309c)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 15, 2025
… method in MockedPulsarServiceBaseTest (apache#24283) (cherry picked from commit 63d35d1) (cherry picked from commit e5d309c)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 15, 2025
… method in MockedPulsarServiceBaseTest (apache#24283) (cherry picked from commit 63d35d1) (cherry picked from commit e5d309c)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 15, 2025
… method in MockedPulsarServiceBaseTest (apache#24283) (cherry picked from commit 63d35d1) (cherry picked from commit b63f685)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2025
… method in MockedPulsarServiceBaseTest (apache#24283) (cherry picked from commit 63d35d1) (cherry picked from commit e5d309c)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 18, 2025
… method in MockedPulsarServiceBaseTest (apache#24283) (cherry picked from commit 63d35d1) (cherry picked from commit b63f685)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 28, 2025
… method in MockedPulsarServiceBaseTest (apache#24283) (cherry picked from commit 63d35d1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
release/3.0.12
release/3.3.7
release/4.0.5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: pdolif#10