Skip to content

Conversation

pdolif
Copy link
Contributor

@pdolif pdolif commented May 9, 2025

Modifications

  • Remove unused parameter from deleteNamespaceWithRetry method in MockedPulsarServiceBaseTest.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: pdolif#10

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 9, 2025
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pdolif

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.18%. Comparing base (bbc6224) to head (66a5c1c).
Report is 1090 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24283      +/-   ##
============================================
+ Coverage     73.57%   74.18%   +0.61%     
+ Complexity    32624    32583      -41     
============================================
  Files          1877     1866      -11     
  Lines        139502   145054    +5552     
  Branches      15299    16580    +1281     
============================================
+ Hits         102638   107612    +4974     
- Misses        28908    28913       +5     
- Partials       7956     8529     +573     
Flag Coverage Δ
inttests 26.65% <ø> (+2.06%) ⬆️
systests 23.28% <ø> (-1.04%) ⬇️
unittests 73.66% <ø> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1080 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari added this to the 4.1.0 milestone May 9, 2025
@lhotari lhotari merged commit 63d35d1 into apache:master May 9, 2025
56 of 57 checks passed
lhotari pushed a commit that referenced this pull request May 9, 2025
… method in MockedPulsarServiceBaseTest (#24283)

(cherry picked from commit 63d35d1)
lhotari pushed a commit that referenced this pull request May 9, 2025
… method in MockedPulsarServiceBaseTest (#24283)

(cherry picked from commit 63d35d1)
lhotari pushed a commit that referenced this pull request May 9, 2025
… method in MockedPulsarServiceBaseTest (#24283)

(cherry picked from commit 63d35d1)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
… method in MockedPulsarServiceBaseTest (apache#24283)

(cherry picked from commit 63d35d1)
(cherry picked from commit b63f685)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
… method in MockedPulsarServiceBaseTest (apache#24283)

(cherry picked from commit 63d35d1)
(cherry picked from commit e5d309c)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
… method in MockedPulsarServiceBaseTest (apache#24283)

(cherry picked from commit 63d35d1)
(cherry picked from commit b63f685)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
… method in MockedPulsarServiceBaseTest (apache#24283)

(cherry picked from commit 63d35d1)
(cherry picked from commit b63f685)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
… method in MockedPulsarServiceBaseTest (apache#24283)

(cherry picked from commit 63d35d1)
(cherry picked from commit e5d309c)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
… method in MockedPulsarServiceBaseTest (apache#24283)

(cherry picked from commit 63d35d1)
(cherry picked from commit e5d309c)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 15, 2025
… method in MockedPulsarServiceBaseTest (apache#24283)

(cherry picked from commit 63d35d1)
(cherry picked from commit e5d309c)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 15, 2025
… method in MockedPulsarServiceBaseTest (apache#24283)

(cherry picked from commit 63d35d1)
(cherry picked from commit e5d309c)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 15, 2025
… method in MockedPulsarServiceBaseTest (apache#24283)

(cherry picked from commit 63d35d1)
(cherry picked from commit e5d309c)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 15, 2025
… method in MockedPulsarServiceBaseTest (apache#24283)

(cherry picked from commit 63d35d1)
(cherry picked from commit b63f685)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 16, 2025
… method in MockedPulsarServiceBaseTest (apache#24283)

(cherry picked from commit 63d35d1)
(cherry picked from commit e5d309c)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 18, 2025
… method in MockedPulsarServiceBaseTest (apache#24283)

(cherry picked from commit 63d35d1)
(cherry picked from commit b63f685)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request May 28, 2025
… method in MockedPulsarServiceBaseTest (apache#24283)

(cherry picked from commit 63d35d1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants