[improve][cli] Make pulsar-perf termination more responsive by using Thread interrupt status #24309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed())" (cherry picked from commit e9daeed8233cefff4b810f060fa7fe01ef7b302a)
heesung-sn
approved these changes
May 15, 2025
dao-jun
approved these changes
May 15, 2025
liudezhi2098
approved these changes
May 16, 2025
liangyepianzhou
approved these changes
May 16, 2025
lhotari
added a commit
that referenced
this pull request
May 16, 2025
…Thread interrupt status (#24309) ### Motivation Terminating pulsar-perf with CTRL-C could take a while. There's also a similar problem in some test cases that I came across while fixing test resource leaks. ### Modifications - replace `while(true)` loops with `while(!Thread.currentThread().isInterrupted())` - properly propagate Thread interrupted information after catching exceptions - fix issue in tests related to runtime hook resource leaks - when the execution completes successfully, remove the shutdown hook and run it without waiting for JVM exit (cherry picked from commit 99ad0e0)
lhotari
added a commit
that referenced
this pull request
May 16, 2025
…Thread interrupt status (#24309) ### Motivation Terminating pulsar-perf with CTRL-C could take a while. There's also a similar problem in some test cases that I came across while fixing test resource leaks. ### Modifications - replace `while(true)` loops with `while(!Thread.currentThread().isInterrupted())` - properly propagate Thread interrupted information after catching exceptions - fix issue in tests related to runtime hook resource leaks - when the execution completes successfully, remove the shutdown hook and run it without waiting for JVM exit (cherry picked from commit 99ad0e0)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 28, 2025
…Thread interrupt status (apache#24309) ### Motivation Terminating pulsar-perf with CTRL-C could take a while. There's also a similar problem in some test cases that I came across while fixing test resource leaks. ### Modifications - replace `while(true)` loops with `while(!Thread.currentThread().isInterrupted())` - properly propagate Thread interrupted information after catching exceptions - fix issue in tests related to runtime hook resource leaks - when the execution completes successfully, remove the shutdown hook and run it without waiting for JVM exit (cherry picked from commit 99ad0e0) (cherry picked from commit e3ed8fc)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 2, 2025
…Thread interrupt status (apache#24309) ### Motivation Terminating pulsar-perf with CTRL-C could take a while. There's also a similar problem in some test cases that I came across while fixing test resource leaks. ### Modifications - replace `while(true)` loops with `while(!Thread.currentThread().isInterrupted())` - properly propagate Thread interrupted information after catching exceptions - fix issue in tests related to runtime hook resource leaks - when the execution completes successfully, remove the shutdown hook and run it without waiting for JVM exit (cherry picked from commit 99ad0e0) (cherry picked from commit e3ed8fc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Terminating pulsar-perf with CTRL-C could take a while. There's also a similar problem in some test cases that I came across while fixing test resource leaks.
Modifications
while(true)loops withwhile(!Thread.currentThread().isInterrupted())Documentation
docdoc-requireddoc-not-neededdoc-complete