[cleanup] Remove unused config autoShrinkForConsumerPendingAcksMap
#24315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
approved these changes
May 19, 2025
|
I wonder whether a pip is required for configuration change. |
autoShrinkForConsumerPendingAcksMapautoShrinkForConsumerPendingAcksMap
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24315 +/- ##
============================================
+ Coverage 73.57% 74.23% +0.66%
+ Complexity 32624 32258 -366
============================================
Files 1877 1866 -11
Lines 139502 145100 +5598
Branches 15299 16591 +1292
============================================
+ Hits 102638 107721 +5083
+ Misses 28908 28863 -45
- Partials 7956 8516 +560
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Seems not, there were some PRs to remove used config without PIP |
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 28, 2025
…pache#24315) (cherry picked from commit 610060e) (cherry picked from commit 612a1d0)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 2, 2025
…pache#24315) (cherry picked from commit 610060e) (cherry picked from commit 612a1d0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The config was introduced by #14515
and deprecated by https://github.com/apache/pulsar/pull/23352/files#diff-6bdf62fdf16d74a56f5f9c1f5a6bf30f4360ad7022c69ab8f90c90a267bc568e
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-complete